stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] exec utility patch
Date Wed, 23 Aug 2006 20:12:05 GMT
Farid Zaripov wrote:

>  > -----Original Message-----
>  > From: Andrew Black [mailto:ablack@roguewave.com]
>  > Sent: Wednesday, August 23, 2006 12:02 AM
>  > To: stdcxx-dev@incubator.apache.org
>  > Subject: Re: [PATCH] exec utility patch
>  >
>  > The first observation I have is that there is a certain
>  > amount of 'noise' in the patch from spelling corrections in
>  > comments.  These spelling fixes should probably be submitted
>  > as a separate cleanup patch.
> 
>   That is VisualAssist plugin for VisualStudio underlines with red
> color the incorrect words and I corrected that words to not see them.
> I have disabled spelling feature for now.

Correcting typos in comments is definitely valuable :) They
should just go in a separate patch so as not to detract from
the other changes during a review. In addition, if the
substantive changes introduced in the patch turn out to be
incorrect after the patch has been applied and need to be
reverted it would be nice not to have to back out the good
fixes for the typos as well.

Martin

Mime
View raw message