stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Farid Zaripov <Far...@kyiv.vdiweb.com>
Subject RE: [PATCH] exec utility patch
Date Wed, 23 Aug 2006 15:19:45 GMT
 > -----Original Message-----
 > From: Andrew Black [mailto:ablack@roguewave.com]
 > Sent: Wednesday, August 23, 2006 12:02 AM
 > To: stdcxx-dev@incubator.apache.org
 > Subject: Re: [PATCH] exec utility patch
 >
 > The first observation I have is that there is a certain
 > amount of 'noise' in the patch from spelling corrections in
 > comments.  These spelling fixes should probably be submitted
 > as a separate cleanup patch.

   That is VisualAssist plugin for VisualStudio underlines with red
color the incorrect words and I corrected that words to not see them.
I have disabled spelling feature for now.

 >
 > The second observation I have is about the use of get_signame
 > on the SIGSEGV constant.  It would be more efficient to use
 > 'puts ("  SEGV\n")
 >   ;' rather than calling printf on a function that returns
 > what is essentially a constant.  An additional benefit is
 > that you wouldn't need to include signal.h.

   Agreed. Corrected patch is attached.

Farid.


Mime
View raw message