stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Black <abl...@roguewave.com>
Subject Re: complex exec util targets [patch]
Date Tue, 01 Aug 2006 19:16:46 GMT
Oops.

That was an artifact from the debugging I was doing for the patch and I 
forgot to remove it.  Fixed in attached.

--Andrew Black

Martin Sebor wrote:
> Andrew Black wrote:
>> Greetings all.
>>
>> Attached is a patch that should allow the exec utility to execute 
>> 'complex' targets.  These targets are executable names with an 
>> associated set of parameters.  If a parameter to a target is %x, the 
>> options specified as the value of the -x command line switch are 
>> inserted at this position in the parameter string for the child process.
>>
> 
> This looks good. Just one thing:
> 
> [...]
>> @@ -228,25 +349,26 @@
>>     @see process_results
>>  */
>>  static void
>> -run_target (char* target, char** childargv)
>> +run_target (char* target, char** argv)
> [...]
>> -    printf ("%-18.18s ", target_name);
>> -    fflush (stdout);
>> +//     printf ("%-18.18s ", target_name);
>> +//     fflush (stdout);
> 
> I assume you didn't really mean to comment these out. Could you
> please resend the patch?
> 
> Thanks
> Martin

Mime
View raw message