Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 35279 invoked from network); 5 Jul 2006 07:10:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Jul 2006 07:10:43 -0000 Received: (qmail 81083 invoked by uid 500); 5 Jul 2006 07:10:43 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 81063 invoked by uid 500); 5 Jul 2006 07:10:43 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 81045 invoked by uid 99); 5 Jul 2006 07:10:43 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2006 00:10:43 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [212.82.213.172] (HELO exkiv.kyiv.vdiweb.com) (212.82.213.172) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jul 2006 00:10:42 -0700 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: 21.strings.cpp bug Date: Wed, 5 Jul 2006 10:10:26 +0300 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: 21.strings.cpp bug Thread-Index: AcafxiH/rb6zy9B1RmykcpkNqi6IRAAO5atw From: "Farid Zaripov" To: X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N > I.e., it seems to me that the loop that iterates over the different > iterator categories and types should be nested in the one that loops over > the tests, and should only be entered when 1 < _rw_argno (test.which, > StringIds::arg_range)) is true. I agree. > What do you think about the attached patch? Looks good. Farid.