Andrew Black wrote: > Greetings all. [...] > Log: > 2006-07-28 Andrew Black > * cmdopt.h (target_name): Declared global variable indicating > current target > * cmdopt.cpp (eval_options): Route unknown option message to stderr > rather than stdout One nit about the ChangeLog: please be consitent in your use of past tense (i.e., "Declared variable..." and "Routed message...") and don't forget to end your sentences with a period :) (Oh, and also remember to capitalize the first letter of each sentence :) Thanks Martin > * cmdopt.cpp (split_child_opts): Cache output of a strlen() call > * util.h (warn): Declared > * util.cpp (warn): Add utility function for generating a (non-fatal) > error message. > * util.cpp (terminate): Add executable and target name to output. > * output.h (parse_output): Alter prototype > * exec.h (exec_file): Ditto > * output.cpp (FILE_TEST, check_example): Alter check_example to > remove reliance on the diff utility, remove FILE_TEST as unneeded. > * output.cpp (check_test, check_compat_test, parse_output): Move > opening of output file to parse_output. > * exec.cpp (wait_for_child, exec_file): use warn() utility > * runall.cpp (check_target_ok): Ditto > * runall.cpp (process_results): Alter signature, alter call to > parse_output > * runall.cpp (run_target): set/use target_name global, alter calls > to exec_file and process_results