Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <44A45359.6040609@roguewave.com>
Date: Thu, 29 Jun 2006 16:25:29 -0600
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: test for lib.string.io
References: <4D6A8407B7AC6F4D95B0E55C4E7C4C62047935DD@exmsk.moscow.vdiweb.com>
In-Reply-To: 
 <4D6A8407B7AC6F4D95B0E55C4E7C4C62047935DD@exmsk.moscow.vdiweb.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Anton Pevtsov wrote:
[...]
> Martin, another question to your changes. There are the following code
> (_ioinsert.cc, line 180):
> 
>             else {
>                 __err = _STD::ios_base::badbit;
> 
> #ifndef _RWSTD_NO_EXT_KEEP_WIDTH_ON_FAILURE
>                 __strm.width (0);   // reset width only on success
> #endif   // _RWSTD_NO_EXT_KEEP_WIDTH_ON_FAILURE
>             }
> 
> But it looks like here should be something like this:
> 
>             else {
>                 __err = _STD::ios_base::badbit;
> 
> #ifdef _RWSTD_NO_EXT_KEEP_WIDTH_ON_FAILURE
>                 __strm.width (0);   // reset width unconditionally
> #endif   // _RWSTD_NO_EXT_KEEP_WIDTH_ON_FAILURE
>             }
> 
> If I have not missed something...

I think you are right. Strangely width_test doesn't catch it.
[Investigating...] Okay, I see why the test doesn't catch it:
because that code path doesn't even get exercised.

Thanks for pointing it out! I think I might go ahead and commit
these changes sometime over the weekend.

Martin