From stdcxx-dev-return-1233-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Wed Apr 26 16:21:59 2006 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 48692 invoked from network); 26 Apr 2006 16:21:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 26 Apr 2006 16:21:58 -0000 Received: (qmail 31410 invoked by uid 500); 26 Apr 2006 16:21:58 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 31393 invoked by uid 500); 26 Apr 2006 16:21:58 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 31382 invoked by uid 99); 26 Apr 2006 16:21:57 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Apr 2006 09:21:57 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Apr 2006 09:21:57 -0700 Received: from bco-exchange.bco.roguewave.com (bco-exchange.bco.roguewave.com [172.19.31.48]) by moroha.quovadx.com (8.13.4/8.13.4) with ESMTP id k3QGLT4n014595 for ; Wed, 26 Apr 2006 16:21:32 GMT Received: from [10.70.3.113] (10.70.3.113 [10.70.3.113]) by bco-exchange.bco.roguewave.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id 2YG6D63H; Wed, 26 Apr 2006 10:18:22 -0600 Message-ID: <444F9E1B.6060309@roguewave.com> Date: Wed, 26 Apr 2006 10:21:47 -0600 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: Tests for lib.string::find methods References: <4D6A8407B7AC6F4D95B0E55C4E7C4C62041BA1FC@exmsk.moscow.vdiweb.com> In-Reply-To: <4D6A8407B7AC6F4D95B0E55C4E7C4C62041BA1FC@exmsk.moscow.vdiweb.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Anton Pevtsov wrote: > Martin, I updated test for the find method. It required several minor > changes to 21.strings.cpp and 21.strings.h. > The most important - I added "int nres" member to the TestCase structure > and updated the existing tests properly. > > The difference files and new test are here: > http://people.apache.org/~antonp/stdcxx04262006/ > > I hope there will be no problems to access them. No problems. The changes look pretty good. I think we should be able to accommodate find without adding the new TestCase member, though. Instead we can reuse res_len. Feel free to rename it to reflect its dual purpose. One other request: could you please change all occurrences of charT in the comments to read value_type and remove the formal argument? E.g., change: find (const charT* s) to find (const value_type*) With these changes please go ahead and commit. [...] > > And there is small question - does stdcxx support 16-bit architectures? It should, even though we're not testing on any at the moment. > If yes we should modify MemberId enum elements to keep them less than 1 > << 16. The underlying type for a C++ emum is required to be wide enough to fit the largest enumerator regardless of the hardware so this should not be a concern on conforming implementations. Martin