Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 50861 invoked from network); 8 Mar 2006 16:46:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 8 Mar 2006 16:46:19 -0000 Received: (qmail 44184 invoked by uid 500); 8 Mar 2006 16:46:19 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 44170 invoked by uid 500); 8 Mar 2006 16:46:19 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 44151 invoked by uid 99); 8 Mar 2006 16:46:18 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2006 08:46:18 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Mar 2006 08:46:17 -0800 Received: from bco-exchange.bco.roguewave.com (bco-exchange.bco.roguewave.com [172.19.31.48]) by moroha.quovadx.com (8.13.4/8.13.4) with ESMTP id k28GjOiW011579 for ; Wed, 8 Mar 2006 16:45:24 GMT Received: from [10.70.3.113] (10.70.3.113 [10.70.3.113]) by bco-exchange.bco.roguewave.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id F5YGRT0S; Wed, 8 Mar 2006 09:44:55 -0700 Message-ID: <440F0B51.1080104@roguewave.com> Date: Wed, 08 Mar 2006 09:50:25 -0700 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: test for 21.strings.capacity References: <440DB698.6030501@moscow.vdiweb.com> <440E1F36.1090900@roguewave.com> In-Reply-To: <440E1F36.1090900@roguewave.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Martin Sebor wrote: > Anton Pevtsov wrote: > >> The attached file contains the updated according to your notes version >> of the test for 21.string.capacity. > > > Thanks! I committed this version here (I forgot that you can commit > it yourself): http://svn.apache.org/viewcvs?rev=384007&view=rev. > > This version still replaces the traits::eof() function even though > string doesn't make use of it. Could you take it out? In fact, since > we have our own UserTraits in rw_char.h, could you replace the > CharTraits class with it? Never mind this. I made the changes myself in the commit below: http://svn.apache.org/viewcvs.cgi?rev=384084&view=rev The UserTraits template also defines its own eof() but that's because the template is also used in the iostreams tests where the function does come in handy. Martin