stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r387240 - /incubator/stdcxx/trunk/tests/strings/21.string.replace.cpp
Date Tue, 21 Mar 2006 02:55:14 GMT
antonp@apache.org wrote:
> Author: antonp
> Date: Mon Mar 20 08:32:51 2006
> New Revision: 387240

Anton, I'm not sure I understand what the parity business is all
about. Could you add a comment to the test explaining what it's
for?

Also, I wonder if we could introduce a descriptive enum for the
which argument. Using hardcoded integers makes the test hard to
follow.

Thanks
Martin

Mime
View raw message