From stdcxx-dev-return-768-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Tue Jan 24 20:50:24 2006 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 48558 invoked from network); 24 Jan 2006 20:50:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 24 Jan 2006 20:50:24 -0000 Received: (qmail 78939 invoked by uid 500); 24 Jan 2006 20:50:24 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 78928 invoked by uid 500); 24 Jan 2006 20:50:23 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 78917 invoked by uid 99); 24 Jan 2006 20:50:23 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2006 12:50:23 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [12.17.213.84] (HELO bco-exchange.bco.roguewave.com) (12.17.213.84) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2006 12:50:23 -0800 Received: from [10.70.3.113] (10.70.3.113 [10.70.3.113]) by bco-exchange.bco.roguewave.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id ZGW2826N; Tue, 24 Jan 2006 13:42:59 -0700 Message-ID: <43D693E6.4010405@roguewave.com> Date: Tue, 24 Jan 2006 13:53:58 -0700 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: 0.new.cpp References: <43CE6FAC.3000507@moscow.vdiweb.com> <43CFE7F6.4060208@roguewave.com> <43D01A83.4020206@roguewave.com> <43D5298C.2060009@roguewave.com> <43D542BD.7040305@roguewave.com> <43D544C9.7070502@roguewave.com> In-Reply-To: <43D544C9.7070502@roguewave.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Liviu Nicoara wrote: > I have attached my attempt at converting new.cpp "self" test to the new > driver. This looks okay but it exposes a problem -- the test produces a bunch of errors like the one below: # ERROR (S8) (4 lines): # TEXT: /build/sebor/dev/stdlib/tests/src/new.cpp:560: deallocation mismatch: pointer allocated 9th in the program with a call to operator new(0) being deallocated with the wrong form of operator delete[](0013c760) I suspect it's because you replaced the calls to fprintf() in new.cpp with those to rw_error(). I still think that was a good change but we need to add to disable it for this test. Btw., I might just commit this test but we need to implement a solution for these (expected) errors sometime soon. The driver has an --expect option that would do this from the command line or from the environment. It seems that setting the --expect option in the environment of the test (programmatically from within the test itself) might be the way to go here. Martin PS Also, the formatting strings passed to the rw_error() calls in new.cpp have redundant trailing newlines -- they should be removed. Could you please make the change and commit it?