Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <43AC7F97.1070300@roguewave.com>
Date: Fri, 23 Dec 2005 15:52:07 -0700
From: Martin Sebor <sebor@roguewave.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: test for lib.alg.replace
References: <43AC193A.7020007@moscow.vdiweb.com>
In-Reply-To: <43AC193A.7020007@moscow.vdiweb.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Anton Pevtsov wrote:
> The attached file contains my attempt to update lib.alg.replace test and
> port it to new test driver.
> 

Thanks! I've committed it with just a few minor changes here:
   http://svn.apache.org/viewcvs.cgi?rev=358878&view=rev

Btw., in the future, could you replace the Rogue Wave copyright
notice at the top of each new file with the one used by STDCXX?

> This test contains implementations of ToString and EqualityPredicate
> classes similar to the implementations which were in the test for the
> remove algorithm. So I suppose move them to alg_test.h and reuse in both
> tests.
> 
> Martin, what do you think about it?

Moving EqualityPredicate is a good idea. Moving the ToString
helper sounds like a good plan for now, too, at least until
we've implemented the same functionality in rw_snprnintfa().

Martin