stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liviu Nicoara <nico...@roguewave.com>
Subject Re: makefile patch
Date Thu, 15 Dec 2005 22:39:56 GMT
Martin Sebor wrote:
> Liviu Nicoara wrote:
> 
> But first a few things about the process :)

Will follow.

> 
> That looks okay. I'm just not too excited about the duplication
> if the code between lib and .DEFAULT. Is there an easy way to
> avoid it?

Not excited about that either. I spent some time thinking about it but I
cannot find an easier way in that many lines of code.

> 
> 
>>I removed the useless builddir target in TOPDIR.
> 
> 
> I guess that's okay, too, except that we will now also need to remove
> the comment explaining builddir. I'm not sure why it was even there if
> it didn't do anything. How does BUILDDIR get created now? By including
> makefile.in?

Yep, it always did it this way.

>>I added dependencies in the BUILDDIR invocations of make (else branch).
> 
> 
> I think we had those at some point in the past. IIRC, I took them out
> because I thought it was cleaner to have them in the individual (sub)
> makefiles instead. I.e., the top level makefile shouldn't need to know
> all the dependencies of each subcomponent. It easy to miss some (such
> as the dependency of tests on rwtest).

I will look into it.

Liviu

Mime
View raw message