stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Sebor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (STDCXX-72) [25.adjacent.find.cpp] predicate form of std::adjacent_find not exercised
Date Sat, 03 Dec 2005 02:41:30 GMT
    [ http://issues.apache.org/jira/browse/STDCXX-72?page=comments#action_12359202 ] 

Martin Sebor commented on STDCXX-72:
------------------------------------

The commit above is an improvement but quoting from
http://mail-archives.apache.org/mod_mbox/incubator-stdcxx-dev/200512.mbox/%3c43907DCF.6040609@roguewave.com%3e:

-------- Original Message --------
Subject: Re: [jira] Created: (STDCXX-72) [25.adjacent.find.cpp] predicate form of std::adjacent_find
not exercised
Date: Fri, 02 Dec 2005 10:01:03 -0700
From: Martin Sebor <sebor@roguewave.com>
Reply-To: stdcxx-dev@incubator.apache.org
To: stdcxx-dev@incubator.apache.org
References: <4D6A8407B7AC6F4D95B0E55C4E7C4C6202F31074@exmsk.moscow.vdiweb.com> <438C7F83.1090802@moscow.vdiweb.com>
<438FAB59.7030106@roguewave.com>

Martin Sebor wrote:
> Anton Pevtsov wrote:
> 
>> The attached file contains my attempt to fix this problem - I added test
>> for the predicate version of adjacent_find.
> 
> 
> This looks good, thanks! I'll go ahead and commit it (we're having
> network trouble so won't probably be until tomorrow).

This is in: http://svn.apache.org/viewcvs.cgi?rev=351771&view=rev

One thing, though. We should avoid using other parts of the library
(such as std:equal_to) when exercising these algorithms. There are
at least two reasons for this: First, the other parts of the library
might themselves be broken which could skew the test results of the
algorithms (and yield false negatives, or worse, false positives).
Second, with the function objects defined by the library we don't
have as much control over the testing environment as we would with
those written specifically for testing purposes.

So instead of the standard function objects we ought to roll our own,
such as we do in 25.for.each.cpp, and use them in the algorithms tests.
Once we've implemented a few of these critters we can move them to
alg_test.h.

Martin


> [25.adjacent.find.cpp] predicate form of std::adjacent_find not exercised
> -------------------------------------------------------------------------
>
>          Key: STDCXX-72
>          URL: http://issues.apache.org/jira/browse/STDCXX-72
>      Project: STDCXX
>         Type: Improvement
>   Components: Tests
>     Versions: 4.1.2
>  Environment: all
>     Reporter: Martin Sebor
>     Priority: Critical
>      Fix For: 4.1.3

>
> The 25.adjacent.find.cpp test doesn't exercise the predicate form of the algorithm. See
http://svn.apache.org/viewcvs.cgi?rev=345300&view=rev.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message