From stdcxx-dev-return-346-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Thu Dec 01 00:30:24 2005 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 99829 invoked from network); 1 Dec 2005 00:30:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Dec 2005 00:30:24 -0000 Received: (qmail 51596 invoked by uid 500); 1 Dec 2005 00:30:24 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 51554 invoked by uid 500); 1 Dec 2005 00:30:23 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 51543 invoked by uid 99); 1 Dec 2005 00:30:23 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2005 16:30:23 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [12.17.213.84] (HELO bco-exchange.bco.roguewave.com) (12.17.213.84) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2005 16:31:52 -0800 Received: from [10.70.3.113] (10.70.3.113 [10.70.3.113]) by bco-exchange.bco.roguewave.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id S0A37KP3; Wed, 30 Nov 2005 17:25:16 -0700 Message-ID: <438E44C6.5080209@roguewave.com> Date: Wed, 30 Nov 2005 17:33:10 -0700 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: questions about the lib.alg.copy test References: <4D6A8407B7AC6F4D95B0E55C4E7C4C6202EEFD7E@exmsk.moscow.vdiweb.com> In-Reply-To: <4D6A8407B7AC6F4D95B0E55C4E7C4C6202EEFD7E@exmsk.moscow.vdiweb.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Anton Pevtsov wrote: > I am porting the lib.alg.copy test to new test driver and I have a > couple of questions about it: Sorry I missed this email... > > 1. Current test version contains calls to to_string function and uses > the tempstr class. This class is defined in the "test.h" header which > should not be included into new test versions. Are these function and > class obsolete or is tere a way to use them in new test versions? Yes, the to_string() helper function is absent from the new driver. There is no equivalent for class X, but the best way to handle it, I think, is along the same lines as in 25.adjacent.find.cpp, i.e., use printable characters instead of integers as values for X.val_. Then we can easily print out the sequence(s) in diagnostics. http://svn.apache.org/repos/asf/incubator/stdcxx/trunk/tests/algorithms/25.adjacent.find.cpp > > 2. The copy algorithm can work in case when the destination range > overlaps the source range (of course, first position of the source range > should not be contained in the destination range). Current version > doesn't contain special test for this case, but I prefer to have such > test. What do you think about it? The requirement in 25.2.1, p3 is that "result shall not be in the range [first, last)." The algorithm doesn't detect violations of this requirement but it probably should in debug mode. This would be a useful enhancement in general. Let me file an enhancement for it. Martin