From dev-return-37541-archive-asf-public=cust-asf.ponee.io@sqoop.apache.org Fri May 10 08:11:51 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 17A37180763 for ; Fri, 10 May 2019 10:11:51 +0200 (CEST) Received: (qmail 24186 invoked by uid 500); 10 May 2019 08:11:50 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 24175 invoked by uid 99); 10 May 2019 08:11:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 08:11:50 +0000 From: GitBox To: dev@sqoop.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bsqoop=5D_dvoros_commented_on_a_change_in_pull_r?= =?utf-8?q?equest_=2380=3A_SQOOP-3438_Sqoop_Import_with_create_hcatalog_ta?= =?utf-8?q?ble_for_ORC_will_not_w=E2=80=A6?= Message-ID: <155747590538.32692.5016498390512363616.gitbox@gitbox.apache.org> Date: Fri, 10 May 2019 08:11:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dvoros commented on a change in pull request #80: SQOOP-3438 Sqoop Import with create hcatalog table for ORC will not w… URL: https://github.com/apache/sqoop/pull/80#discussion_r282785214 ########## File path: src/java/org/apache/sqoop/SqoopOptions.java ########## @@ -1654,6 +1656,14 @@ public String getHCatTableName() { return this.hCatTableName; } + public void useExternalHCatTable(boolean value) { Review comment: Nit: Other boolean setter methods are called `set*` here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services