From dev-return-35991-archive-asf-public=cust-asf.ponee.io@sqoop.apache.org Thu Apr 26 13:23:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 49970180648 for ; Thu, 26 Apr 2018 13:23:06 +0200 (CEST) Received: (qmail 85764 invoked by uid 500); 26 Apr 2018 11:23:05 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 85753 invoked by uid 99); 26 Apr 2018 11:23:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Apr 2018 11:23:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E327C1A1F14 for ; Thu, 26 Apr 2018 11:23:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -102.311 X-Spam-Level: X-Spam-Status: No, score=-102.311 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LFtEgjr0CFyb for ; Thu, 26 Apr 2018 11:23:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4B3F65F666 for ; Thu, 26 Apr 2018 11:23:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 34699E1247 for ; Thu, 26 Apr 2018 11:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 58EEB2109B for ; Thu, 26 Apr 2018 11:23:00 +0000 (UTC) Date: Thu, 26 Apr 2018 11:23:00 +0000 (UTC) From: "Tijmen Ramakers (JIRA)" To: dev@sqoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (SQOOP-3320) Commit behaviour leads to exceptions on read-only database MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SQOOP-3320?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:all-tabpanel ] Tijmen Ramakers updated SQOOP-3320: ----------------------------------- Summary: Commit behaviour leads to exceptions on read-only database (w= as: Commit behaviour leads to errors on read-only databases) > Commit behaviour leads to exceptions on read-only database > ---------------------------------------------------------- > > Key: SQOOP-3320 > URL: https://issues.apache.org/jira/browse/SQOOP-3320 > Project: Sqoop > Issue Type: Bug > Components: connectors/generic > Affects Versions: 1.4.7 > Reporter: Tijmen Ramakers > Priority: Major > > The current Sqoop behaviour is to do a commit after having retrieved the = results of a query. This leads to errors when the database (or the connecti= on) is in read-only mode. > Example stack traces: > {code:java} > ERROR manager.SqlManager: SQLException closing ResultSet: org.netezza.err= or.NzSQLException: ERROR:=C2=A0 Database 'XXXPRD' is available for read-onl= y > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.netezza.internal.QueryExecut= or.getNextResult(QueryExecutor.java:280) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.netezza.internal.QueryE= xecutor.execute(QueryExecutor.java:76) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.netezza.sql.NzConnectio= n.execute(NzConnection.java:2819) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.netezza.sql.NzConnectio= n.execute(NzConnection.java:2791) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.netezza.sql.NzConnectio= n.commit(NzConnection.java:1161) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.apache.sqoop.manager.Sq= lManager.getColumnNamesForRawQuery(SqlManager.java:182) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.apache.sqoop.manager.Sq= lManager.getColumnNamesForQuery(SqlManager.java:142) > {code} > {code:java} > tool.EvalSqlTool: SQL exception executing statement: org.netezza.error.Nz= SQLException: ERROR:=C2=A0 Database 'XXXPRD' is available for read-only =C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.netezza.internal.QueryExecut= or.getNextResult(QueryExecutor.java:280) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 at org.netezza.internal.QueryExecutor.execute(QueryExecutor.java:= 76) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.netezza.sql.NzConnect= ion.execute(NzConnection.java:2819) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 at org.netezza.sql.NzConnection.execute(NzConnection.java:2791) =C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.netezza.sql.NzConnection.commit= (NzConnection.java:1161) =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 at org.= apache.sqoop.tool.EvalSqlTool.run(EvalSqlTool.java:78) =C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 at org.apache.sqoop.Sqoop.run(Sqoop.java:147) > =C2=A0 > {code} > =C2=A0 > When using _sqoop eval_, it is not a major issue since it happens after t= he data is already fetched and displayed. When using _sqoop import_ however= , the spawned mapreduce jobs all fail, so this is blocking the whole import= . > This commit behaviour exists in several methods, at least the following: > org.apache.sqoop.tool.EvalSqlTool::run (line 78) > org.apache.sqoop.mapreduce.db.DBRecordReader::close (line 169) > org.apache.sqoop.manager.SqlManager::getColumnNamesForRawQuery (line 182) > org.apache.sqoop.manager.SqlManager::getColumnNamesForProcedure (line 226= ) > =C2=A0 > When a connection is in autocommit mode, then a manual commit is not need= ed anyway. When a connection is in read-only mode, then it should still be = possible to do a rollback in order to close an outstanding transaction. > I propose to change the mentioned method lines ("connection.commit();" or= equivalent), to: > {code:java} > if (!connection.getAutoCommit()) { > =C2=A0 if (connection.isReadOnly()) > =C2=A0=C2=A0=C2=A0 connection.rollback(); > =C2=A0 else > =C2=A0=C2=A0=C2=A0 connection.commit(); > } > {code} > (or equivalent) > =C2=A0 > (Overall, I don't know why a commit is done in the above mentioned method= s, as data should have only been read, if the idea is to just close the tra= nsaction, why not do a rollback instead just as a safety measure?) -- This message was sent by Atlassian JIRA (v7.6.3#76005)