From dev-return-35982-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Tue Apr 24 13:17:45 2018 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 18369181B1 for ; Tue, 24 Apr 2018 13:17:45 +0000 (UTC) Received: (qmail 69958 invoked by uid 500); 24 Apr 2018 13:17:44 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 69924 invoked by uid 500); 24 Apr 2018 13:17:44 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 69909 invoked by uid 500); 24 Apr 2018 13:17:44 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 69906 invoked by uid 99); 24 Apr 2018 13:17:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2018 13:17:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A55C6C1160; Tue, 24 Apr 2018 13:17:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.15 X-Spam-Level: * X-Spam-Status: No, score=1.15 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_MANYTO=0.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id x_1Obvc4R5ho; Tue, 24 Apr 2018 13:17:38 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9ACC65F238; Tue, 24 Apr 2018 13:17:38 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2B1D5E00C6; Tue, 24 Apr 2018 13:17:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A6397C400F6; Tue, 24 Apr 2018 13:17:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3352411113569170827==" MIME-Version: 1.0 Subject: Re: Review Request 66067: SQOOP-3052: Introduce gradle-based build for Sqoop to make it more developer friendly / open From: Fero Szabo via Review Board To: Szabolcs Vasas , Fero Szabo , Sqoop , Anna Szonyi , Boglarka Egyed , daniel voros Date: Tue, 24 Apr 2018 13:17:37 -0000 Message-ID: <20180424131737.52378.92420@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Fero Szabo X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/66067/ X-Sender: Fero Szabo References: <20180424122402.52378.19905@reviews-vm2.apache.org> In-Reply-To: <20180424122402.52378.19905@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: gradle/sqoop-version-gen.gradle X-ReviewBoard-Diff-For: config/checkstyle/checkstyle-java-header.txt X-ReviewBoard-Diff-For: gradle.properties X-ReviewBoard-Diff-For: gradle/customWindowsStartScript.txt X-ReviewBoard-Diff-For: gradle/customUnixStartScript.txt X-ReviewBoard-Diff-For: gradle/wrapper/gradle-wrapper.jar X-ReviewBoard-Diff-For: gradlew X-ReviewBoard-Diff-For: gradle/wrapper/gradle-wrapper.properties X-ReviewBoard-Diff-For: gradlew.bat X-ReviewBoard-Diff-For: config/checkstyle/checkstyle.xml X-ReviewBoard-Diff-For: config/checkstyle/checkstyle-noframes.xsl X-ReviewBoard-Diff-For: settings.gradle X-ReviewBoard-Diff-For: build.gradle X-ReviewBoard-Diff-For: gradle/sqoop-package.gradle Reply-To: Fero Szabo X-ReviewRequest-Repository: sqoop-trunk --===============3352411113569170827== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 24, 2018, 12:24 p.m., Fero Szabo wrote: > > build.gradle > > Lines 349 (patched) > > > > > > When running the docs task, I get 55 warnings and the BUILD FAILED message. Can you please fix it? (Should we just ignore the warnings?) > > > > Please get back to me, if you need the logs, I'll run it again. There are warnings, but it's successful now, let's drop this issue - Fero ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66067/#review201828 ----------------------------------------------------------- On April 23, 2018, 10:40 a.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66067/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 10:40 a.m.) > > > Review request for Sqoop. > > > Bugs: Sqoop-3052 > https://issues.apache.org/jira/browse/Sqoop-3052 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3052: Introduce gradle based build for Sqoop to make it more developer friendly / open > > > Diffs > ----- > > .gitignore 68cbe28731e613607c208824443d1edf256d9c8a > COMPILING.txt 3b82250488256871352056e9061ad08fabbd7fc5 > build.gradle PRE-CREATION > config/checkstyle/checkstyle-java-header.txt PRE-CREATION > config/checkstyle/checkstyle-noframes.xsl PRE-CREATION > config/checkstyle/checkstyle.xml PRE-CREATION > gradle.properties PRE-CREATION > gradle/customUnixStartScript.txt PRE-CREATION > gradle/customWindowsStartScript.txt PRE-CREATION > gradle/sqoop-package.gradle PRE-CREATION > gradle/sqoop-version-gen.gradle PRE-CREATION > gradle/wrapper/gradle-wrapper.jar PRE-CREATION > gradle/wrapper/gradle-wrapper.properties PRE-CREATION > gradlew PRE-CREATION > gradlew.bat PRE-CREATION > settings.gradle PRE-CREATION > src/scripts/rat-violations.sh 1cfbc1502b24dd1b8b7e7ce21f0b5d1880c06556 > testdata/hcatalog/conf/hive-site.xml edac7aa9087a84b7a0c660907794adae684ae313 > > > Diff: https://reviews.apache.org/r/66067/diff/9/ > > > Testing > ------- > > ran all new tasks, except for internal maven publishing > > Notes: > - To try it out you can call ./gradlew tasks --all to see all the tasks and compare them to current tasks/artifacts. > - Replaced cobertura with jacoco, as it's easier/cleaner to configure, easier to combine all test results into a single report. > - Generated pom.xml now has correct dependencies/versions > - Script generation is currently hardcoded and not based on sqoop help, as previously - though added the possiblity of hooking it in later > > > Thanks, > > Anna Szonyi > > --===============3352411113569170827==--