From dev-return-33505-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Tue Jan 3 11:06:56 2017 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD1F919017 for ; Tue, 3 Jan 2017 11:06:56 +0000 (UTC) Received: (qmail 35456 invoked by uid 500); 3 Jan 2017 11:06:51 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 35426 invoked by uid 500); 3 Jan 2017 11:06:51 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 35400 invoked by uid 500); 3 Jan 2017 11:06:51 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 35392 invoked by uid 99); 3 Jan 2017 11:06:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jan 2017 11:06:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E5677310A42; Tue, 3 Jan 2017 11:06:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4975138135759758364==" MIME-Version: 1.0 Subject: Re: Review Request 55103: Clean up expected exception logic in tests - part II. From: Anna Szonyi To: Anna Szonyi , Attila Szabo Cc: Boglarka Egyed , Sqoop Date: Tue, 03 Jan 2017 11:06:50 -0000 Message-ID: <20170103110650.13569.43153@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anna Szonyi X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55103/ X-Sender: Anna Szonyi X-ReviewBoard-ShipIt: 1 References: <20161230152931.1483.44551@reviews.apache.org> In-Reply-To: <20161230152931.1483.44551@reviews.apache.org> Reply-To: Anna Szonyi X-ReviewRequest-Repository: sqoop-trunk --===============4975138135759758364== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55103/#review160368 ----------------------------------------------------------- Ship it! Thanks for the cleanup effort, it's much better this way! Thanks, Anna - Anna Szonyi On Dec. 30, 2016, 3:29 p.m., Boglarka Egyed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55103/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2016, 3:29 p.m.) > > > Review request for Sqoop, Attila Szabo and Anna Szonyi. > > > Bugs: SQOOP-3092 > https://issues.apache.org/jira/browse/SQOOP-3092 > > > Repository: sqoop-trunk > > > Description > ------- > > Normalizing test cases where we except an exception using JUnit's ExpectedException rule to make the code mor clean and self-explanatory. > > > Diffs > ----- > > src/test/com/cloudera/sqoop/hive/TestHiveImport.java 26d087b0bede24afbcd029ce0aaa03b355b60040 > src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 55e572ed11a5c9e765d3204881bb31d258a6f540 > src/test/com/cloudera/sqoop/io/TestCodecMap.java 925c5446ab878786bc6403b06e458839cc603039 > src/test/com/cloudera/sqoop/io/TestLobFile.java 129b03a5307f47fc3ba950fb93b528292682b229 > src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java 54b4552a792e5a4cf92a31a7e8d3354488de1a0e > src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java 5cfb0a5a1998817311de033eb93686c9a3007237 > src/test/org/apache/sqoop/mapreduce/db/TextSplitterHadoopConfIntegrationTest.java 043130ea8d806cf9e465e650a89a811a4be7bb7a > > Diff: https://reviews.apache.org/r/55103/diff/ > > > Testing > ------- > > ant test, ant clean test > > > Thanks, > > Boglarka Egyed > > --===============4975138135759758364==--