> On Jan. 11, 2017, 10:31 a.m., Attila Szabo wrote:
> > Hey Anna,
> >
> > Just a first comment (as your change is quite big, and didn't reach the end of it
yet ;-) ):
> > What is our intention about deleting the suites?
> >
> > AFAIK Junit4 also support suites.
> > I would be abel to raise pros and cons also, so I'd like to understand your motivation
here first.
> >
> > Thanks for the calrification!
> >
> > Attila
>
> Anna Szonyi wrote:
> Hi Attila,
>
> While JUnit4 has support for test suites, I kind of feel that tests suites tend to
not add all that much value, as they get outdated very quickly (you create a new MYSQL test
and forget to add it) and as we have another separation of tests as well currently (Unit,
3rd party, manual) and I am unsure if we ever ran a combination of these.
> I also think that the current categories were outdated (AllTests -which did not have
all the tests, SmokeTests, MapreduceTests, ManualMySqlTests...) - in its current form I don't
see it adding a lot of value. I think a suite/categorization would make most sense for 3rd
party tests for the different resources (Oracle, Mysql, Cubrid, Postgres), which we don't
currently have.
> However I am completely fine with re-adding the test suites as they were.
>
> Thanks,
> Anna
>
> Anna Szonyi wrote:
> Hi Attila,
>
> I've created an improvement JIRA SQOOP-3014 to create test categories instead of
suites. Please let me know your thoughts.
>
> Thanks,
> Anna
>
> Anna Szonyi wrote:
> *3104
Hey Anna,
Sounds fair enough. However in this case I'd like to ask you to fire a new JIRA for adding
these test categories (which IMHO is a very good idea).
Thanks,
Attila
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55142/#review161201
-----------------------------------------------------------
On Jan. 11, 2017, 3:42 p.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55142/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 3:42 p.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Liz Szilagyi.
>
>
> Bugs: SQOOP-3099
> https://issues.apache.org/jira/browse/SQOOP-3099
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP-3099 Remove all junit3 TestCase extension and test suites
>
>
> Diffs
> -----
>
> src/test/com/cloudera/sqoop/AllTests.java 1dfb0fc
> src/test/com/cloudera/sqoop/SmokeTests.java c5dc860
> src/test/com/cloudera/sqoop/TestAllTables.java f981024
> src/test/com/cloudera/sqoop/TestAppendUtils.java b09dfc6
> src/test/com/cloudera/sqoop/TestAvroExport.java 750887a
> src/test/com/cloudera/sqoop/TestAvroImport.java 0a64b52
> src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java fd4275d
> src/test/com/cloudera/sqoop/TestBoundaryQuery.java 99f652e
> src/test/com/cloudera/sqoop/TestCompression.java 841f054
> src/test/com/cloudera/sqoop/TestConnFactory.java ff41706
> src/test/com/cloudera/sqoop/TestDirectImport.java f48c112
> src/test/com/cloudera/sqoop/TestExport.java 00d17c2
> src/test/com/cloudera/sqoop/TestExportUpdate.java 33a176a
> src/test/com/cloudera/sqoop/TestFreeFormQueryImport.java 81f1c59
> src/test/com/cloudera/sqoop/TestIncrementalImport.java d62532c
> src/test/com/cloudera/sqoop/TestMerge.java 1709419
> src/test/com/cloudera/sqoop/TestMultiCols.java e165cfe
> src/test/com/cloudera/sqoop/TestMultiMaps.java ac23229
> src/test/com/cloudera/sqoop/TestParquetExport.java 94122f6
> src/test/com/cloudera/sqoop/TestParquetImport.java 2a6dd6c
> src/test/com/cloudera/sqoop/TestQuery.java 04d6ec4
> src/test/com/cloudera/sqoop/TestSplitBy.java 8ab1eef
> src/test/com/cloudera/sqoop/TestSqoopOptions.java 84dc7b0
> src/test/com/cloudera/sqoop/TestTargetDir.java 4816e70
> src/test/com/cloudera/sqoop/TestWhere.java c989d20
> src/test/com/cloudera/sqoop/ThirdPartyTests.java 7e10c68
> src/test/com/cloudera/sqoop/hbase/HBaseImportAddRowKeyTest.java abf9f1c
> src/test/com/cloudera/sqoop/hbase/HBaseImportNullTest.java 58566fc
> src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java a5e1bea
> src/test/com/cloudera/sqoop/hbase/HBaseQueryImportTest.java 28b9026
> src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java ad92a07
> src/test/com/cloudera/sqoop/hbase/HBaseUtilTest.java 166eef3
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1253e8d
> src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 8d6b9d5
> src/test/com/cloudera/sqoop/io/TestCodecMap.java 867f1d5
> src/test/com/cloudera/sqoop/io/TestLobFile.java d056750
> src/test/com/cloudera/sqoop/io/TestNamedFifo.java 40f9b3b
> src/test/com/cloudera/sqoop/io/TestSplittableBufferedWriter.java c00b6b3
> src/test/com/cloudera/sqoop/lib/TestBlobRef.java d19b769
> src/test/com/cloudera/sqoop/lib/TestBooleanParser.java 7449c39
> src/test/com/cloudera/sqoop/lib/TestClobRef.java 7e961c0
> src/test/com/cloudera/sqoop/lib/TestFieldFormatter.java 1d2d29a
> src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java e0ca67c
> src/test/com/cloudera/sqoop/lib/TestRecordParser.java 8b11d39
> src/test/com/cloudera/sqoop/manager/CubridManagerExportTest.java 4fa74fb
> src/test/com/cloudera/sqoop/manager/CubridManagerImportTest.java a683e20
> src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java 3d9f817
> src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 7f08675
> src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java faa0a3e
> src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 5c6e567
> src/test/com/cloudera/sqoop/manager/ManualMySQLTests.java 4d06dd9
> src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java 57900ee
> src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 5bf920a
> src/test/com/cloudera/sqoop/manager/OracleExportTest.java 07d672f
> src/test/com/cloudera/sqoop/manager/OracleLobAvroImportTest.java b79f87c
> src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 396f897
> src/test/com/cloudera/sqoop/manager/PGBulkloadManagerManualTest.java a93da71
> src/test/com/cloudera/sqoop/manager/PostgresqlExportTest.java 0ac4599
> src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 5fddd58
> src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 5f934c3
> src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 09f1e6b
> src/test/com/cloudera/sqoop/manager/TestHsqldbManager.java d64a2cc
> src/test/com/cloudera/sqoop/manager/TestSqlManager.java 57855fa
> src/test/com/cloudera/sqoop/mapreduce/MapreduceTests.java 3f97798
> src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java d3f5549
> src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java fed22b8
> src/test/com/cloudera/sqoop/mapreduce/db/TestIntegerSplitter.java c072fa0
> src/test/com/cloudera/sqoop/mapreduce/db/TestTextSplitter.java 4927c74
> src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 0ac6bdc
> src/test/com/cloudera/sqoop/orm/TestClassWriter.java 10a0969
> src/test/com/cloudera/sqoop/orm/TestParseMethods.java cec7614
> src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java f8021be
> src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java e2adc52
> src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java 08408a5
> src/test/com/cloudera/sqoop/testutil/LobAvroImportTestCase.java 468673f
> src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java ecbaa83
> src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1793626
> src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java 3f0bfb9
> src/test/com/cloudera/sqoop/util/TestSubstitutionUtils.java cd13adc
> src/test/org/apache/sqoop/TestAutoResetMapper.java 4c8282c
> src/test/org/apache/sqoop/TestBigDecimalExport.java 80cdad5
> src/test/org/apache/sqoop/TestBigDecimalImport.java 76e4704
> src/test/org/apache/sqoop/TestExportUsingProcedure.java 8182c8d
> src/test/org/apache/sqoop/TestSqoopJobDataPublisher.java e9698be
> src/test/org/apache/sqoop/TestSqoopOptions.java fdb8c8d
> src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java 9000f5d
> src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java d52f0f0
> src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java be73594
> src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java c236b8a
> src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java 5b170b6
> src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 5ef9b2b
> src/test/org/apache/sqoop/hcat/HCatalogImportTest.java 28f83f2
> src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java d3337c7
> src/test/org/apache/sqoop/manager/TestMainframeManager.java 79cbcb1
> src/test/org/apache/sqoop/manager/TestSqlManager.java 08413b0
> src/test/org/apache/sqoop/manager/cubrid/CubridAuthTest.java ed6ba3b
> src/test/org/apache/sqoop/manager/mysql/MySqlCallExportTest.java 420ab19
> src/test/org/apache/sqoop/manager/mysql/MySqlColumnEscapeImportTest.java 8a6b6fe
> src/test/org/apache/sqoop/manager/netezza/DirectNetezzaExportManualTest.java 92012c4
> src/test/org/apache/sqoop/manager/netezza/DirectNetezzaHCatExportManualTest.java dbf9988
> src/test/org/apache/sqoop/manager/netezza/DirectNetezzaHCatImportManualTest.java cf56714
> src/test/org/apache/sqoop/manager/netezza/NetezzaExportManualTest.java 9ba65a8
> src/test/org/apache/sqoop/manager/netezza/NetezzaImportManualTest.java 6a6ed0c
> src/test/org/apache/sqoop/manager/oracle/ExportTest.java 3752886
> src/test/org/apache/sqoop/manager/oracle/ImportTest.java 5db9bc2
> src/test/org/apache/sqoop/manager/oracle/OraOopDataDrivenDBInputFormatConnectionCloseTest.java
59b6e3a
> src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java 3811e38
> src/test/org/apache/sqoop/manager/oracle/OracleCallExportTest.java 1d3417a
> src/test/org/apache/sqoop/manager/oracle/OracleColumnEscapeImportTest.java d428040
> src/test/org/apache/sqoop/manager/oracle/OracleIncrementalImportTest.java e596646
> src/test/org/apache/sqoop/manager/oracle/OracleSplitterTest.java fc5f56b
> src/test/org/apache/sqoop/manager/oracle/TestOraOopJdbcUrl.java e842849
> src/test/org/apache/sqoop/manager/oracle/TestOraOopUtilities.java 93592af
> src/test/org/apache/sqoop/manager/oracle/TestOracleTable.java 854d826
> src/test/org/apache/sqoop/manager/oracle/TimestampDataTest.java 6ceccd1
> src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java 73976a3
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java
97034a1
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java
87bc203
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java
8b30da0
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java 077613f
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java ee576c9
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java 66b4a51
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java 58ef4b4
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java 21c950a
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java 613bbce
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java 4729aac
> src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java 9fad144
> src/test/org/apache/sqoop/mapreduce/TestJdbcExportJob.java 19440ff
> src/test/org/apache/sqoop/mapreduce/TestJobBase.java f228a35
> src/test/org/apache/sqoop/mapreduce/db/TestBigDecimalSplitter.java 1e557a5
> src/test/org/apache/sqoop/mapreduce/db/TestDBConfiguration.java cad1004
> src/test/org/apache/sqoop/mapreduce/db/TestIntegerSplitter.java e93b6ad
> src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java c402a54
> src/test/org/apache/sqoop/mapreduce/db/TextSplitterHadoopConfIntegrationTest.java 32ebf45
> src/test/org/apache/sqoop/tool/TestBaseSqoopTool.java fbbffe9
> src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 3e502d0
> src/test/org/apache/sqoop/validation/AbortOnFailureHandlerTest.java f38164c
> src/test/org/apache/sqoop/validation/AbsoluteValidationThresholdTest.java 9ac5074
> src/test/org/apache/sqoop/validation/RowCountValidatorImportTest.java 035d3b1
>
> Diff: https://reviews.apache.org/r/55142/diff/
>
>
> Testing
> -------
>
> ant clean test, ant clean test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=3rdpartylib
-Dsqoop.test.mysql.connectstring.host_url=mysqlserver -Dsqoop.test.mysql.databasename=sqoop
-Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop -Dsqoop.test.oracle.connectstring=oracleserver
-Dsqoop.test.postgresql.connectstring.host_url=postgresqlserver -Dsqoop.test.cubrid.connectstring.host_url=cubridserver
-Dsqoop.test.cubrid.connectstring.username=sqoop -Dsqoop.test.cubrid.connectstring.database=sqoop
-Dsqoop.test.cubrid.connectstring.password=sqoop -Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
-Dtest.timeout=1000000
>
>
> Thanks,
>
> Anna Szonyi
>
>
|