Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 030C4200BDC for ; Wed, 14 Dec 2016 10:52:29 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 01A20160B19; Wed, 14 Dec 2016 09:52:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4A97F160B13 for ; Wed, 14 Dec 2016 10:52:28 +0100 (CET) Received: (qmail 27761 invoked by uid 500); 14 Dec 2016 09:52:27 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 27748 invoked by uid 500); 14 Dec 2016 09:52:27 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 27737 invoked by uid 99); 14 Dec 2016 09:52:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Dec 2016 09:52:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D83AA1C03B2; Wed, 14 Dec 2016 09:52:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3904794278635025380==" MIME-Version: 1.0 Subject: Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat From: Anna Szonyi To: Szabolcs Vasas , Attila Szabo Cc: Boglarka Egyed , Anna Szonyi , Erzsebet Szilagyi , Sqoop Date: Wed, 14 Dec 2016 09:52:25 -0000 Message-ID: <20161214095225.17252.88524@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anna Szonyi X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54699/ X-Sender: Anna Szonyi References: <20161213142911.17252.26573@reviews.apache.org> In-Reply-To: <20161213142911.17252.26573@reviews.apache.org> Reply-To: Anna Szonyi X-ReviewRequest-Repository: sqoop-trunk archived-at: Wed, 14 Dec 2016 09:52:29 -0000 --===============3904794278635025380== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/ ----------------------------------------------------------- (Updated Dec. 14, 2016, 9:52 a.m.) Review request for Sqoop, Attila Szabo and Szabolcs Vasas. Changes ------- made it compliant with 3066 + fixed per reviews Bugs: SQOOP-3081 https://issues.apache.org/jira/browse/SQOOP-3081 Repository: sqoop-trunk Description ------- SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In OracleUpsertOutputFormat to make it consistent with the rest of the code and add escaping to the rest of the column variables. Diffs (updated) ----- src/java/org/apache/sqoop/SqoopOptions.java 53cc03a src/java/org/apache/sqoop/manager/oracle/OracleUtils.java aa56e70 src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 Diff: https://reviews.apache.org/r/54699/diff/ Testing ------- ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib -Dthirdparty=true -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=1000000 -Dtestcase=*racle*Test with special attention to OracleExportTest#testUpsertTextExport Thanks, Anna Szonyi --===============3904794278635025380==--