sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anna Szonyi <szo...@cloudera.com>
Subject Re: Review Request 54575: SQOOP-3075: Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils
Date Fri, 16 Dec 2016 10:48:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54575/#review159426
-----------------------------------------------------------


Ship it!




Ship It!

- Anna Szonyi


On Dec. 16, 2016, 10:46 a.m., Attila Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54575/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2016, 10:46 a.m.)
> 
> 
> Review request for Sqoop and Anna Szonyi.
> 
> 
> Bugs: SQOOP-3075
>     https://issues.apache.org/jira/browse/SQOOP-3075
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Although SQOOP-3074 achieved that Sqoop won't fail anymore with special characters even
if the locale on the caller system is not UTF-8, there's a simpler solution to do the same
thing, by tuning the compiler + classwriter itself (by adding explicit encodings) instead
of using the StringEscapeUtils#escapeJava mechanism.
> This solution seems simpler, and won't introduce any confusion around generation of Java
identifiers.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/avro/AvroUtil.java 8d901302 
>   src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 5b1c7457 
>   src/java/org/apache/sqoop/orm/ClassWriter.java 0c8d86d0 
>   src/java/org/apache/sqoop/orm/CompilationManager.java 0a2a87f2 
> 
> Diff: https://reviews.apache.org/r/54575/diff/
> 
> 
> Testing
> -------
> 
> ant clean test
> 
> ant clean test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=/root -Dsqoop.test.mysql.connectstring.host_url=jdbc:mysql://mysqlhostname/
-Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop
-Dsqoop.test.oracle.connectstring=jdbc:oracle:thin:@//oraclehostname/orcl -Dsqoop.test.postgresql.connectstring.host_url=jdbc:postgresql://postgreshostname/
-Dsqoop.test.cubrid.connectstring.host_url=jdbc:cubrid:cubridhotname:33000 -Dsqoop.test.cubrid.connectstring.username=sqoop
-Dsqoop.test.cubrid.connectstring.database=sqoop -Dsqoop.test.cubrid.connectstring.password=sqoop
-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=1000000
> 
> 
> Thanks,
> 
> Attila Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message