Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@sqoop.apache.org
Content-Type: multipart/alternative;
 boundary="===============5411484128917713595=="
MIME-Version: 1.0
Subject: Re: Review Request 53600: SQOOP-3027 Create check/fail fast for Sqoop
 export and import with --hcatalog-table <HIVE_VIEW>,
 as it's not supported by Hive + MR
From: Attila Szabo <maugli@apache.org>
To: Attila Szabo <maugli@apache.org>
Cc: Anna Szonyi <szonyi@cloudera.com>, Sqoop <sqoop-dev@incubator.apache.org>
Date: Sat, 12 Nov 2016 18:18:38 -0000
Message-ID: <20161112181838.1691.86100@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Attila Szabo <noreply@reviews.apache.org>
References: <20161110160547.1690.90292@reviews.apache.org>
In-Reply-To: <20161110160547.1690.90292@reviews.apache.org>
Reply-To: Attila Szabo <maugli@apache.org>
archived-at: Sat, 12 Nov 2016 18:18:41 -0000

--===============5411484128917713595==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53600/#review155783
-----------------------------------------------------------


Hi Anna,

With your current change the latest profile (HADOOP260) and the default profile (HADOOP200) is not able to run the test cases related to this change (e.g. HCatalogImportTest). The root cause seems to me a binary incompatibility between the HCat jars and HADOOP jars (e.g. JobConf is not an interface anymore).

Although with some older profiles (HADOOP100) the original version of HCatalogImportTest passes, but your additional test cases not.

I'd like to kindly ask you to fix at least HADOOP260 [the rest of the profiles planned to go away in the near future] profile to being able to run all the realted tests (on my side version 1.2.0 seemed to be working out of the box, but I let you to do the investigation which version would be the most appropriate here).

Another slit change:
Please also add the following statement "utils.dropHCatTableIfExists(table, SqoopHCatUtilities.DEFHCATDB);" into HCatalogImportTest#testPublishTableImportData(), as it seemed to be failing on my side without that in case of reruns.

Thanks,
Attila

- Attila Szabo


On Nov. 10, 2016, 4:05 p.m., Anna Szonyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53600/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 4:05 p.m.)
> 
> 
> Review request for Sqoop and Attila Szabo.
> 
> 
> Bugs: SQOOP-3027
>     https://issues.apache.org/jira/browse/SQOOP-3027
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-3027: Added check/fail fast for Sqoop export and import with --hcatalog-table <HIVE_VIEW>, as it's not supported by Hive + MapReduce (see: https://cwiki.apache.org/confluence/display/Hive/HCatalog+CLI#HCatalogCLI-Create/Drop/AlterView)
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java ebe7209 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 468bf34 
>   src/test/org/apache/sqoop/hcat/HCatalogExportTest.java ff3dde1 
>   src/test/org/apache/sqoop/hcat/HCatalogImportTest.java fe5295a 
>   src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java fb4a200 
> 
> Diff: https://reviews.apache.org/r/53600/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests for import, export and view check. Ran ant test.
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>


--===============5411484128917713595==--