Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D62E6200BB6 for ; Fri, 4 Nov 2016 10:23:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D1798160AE9; Fri, 4 Nov 2016 09:23:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C0C99160AE8 for ; Fri, 4 Nov 2016 10:23:36 +0100 (CET) Received: (qmail 60264 invoked by uid 500); 4 Nov 2016 09:23:36 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 60253 invoked by uid 500); 4 Nov 2016 09:23:35 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 60243 invoked by uid 99); 4 Nov 2016 09:23:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 09:23:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2B3CD2DCE73; Fri, 4 Nov 2016 09:23:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2787292050157413057==" MIME-Version: 1.0 Subject: Re: Review Request 53423: SQOOP-2349 Transaction isolation level for metadata queries should be mutable From: Anna Szonyi To: Szabolcs Vasas , Boglarka Egyed , Anna Szonyi , Abraham Elmahrek , Abraham Fine , Erzsebet Szilagyi Cc: Attila Szabo , Sqoop Date: Fri, 04 Nov 2016 09:23:35 -0000 Message-ID: <20161104092335.31640.79795@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Anna Szonyi X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53423/ X-Sender: Anna Szonyi X-ReviewBoard-ShipIt: 1 References: <20161104035200.1745.49068@reviews.apache.org> In-Reply-To: <20161104035200.1745.49068@reviews.apache.org> X-ReviewBoard-Diff-For: src/test/org/apache/sqoop/tool/TestImportTool.java Reply-To: Anna Szonyi X-ReviewRequest-Repository: sqoop-trunk archived-at: Fri, 04 Nov 2016 09:23:38 -0000 --===============2787292050157413057== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53423/#review154882 ----------------------------------------------------------- Ship it! Thanks for adding the test, seems great! Thanks, /Anna - Anna Szonyi On Nov. 4, 2016, 3:52 a.m., Attila Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53423/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 3:52 a.m.) > > > Review request for Sqoop, Abraham Elmahrek, Abraham Fine, Boglarka Egyed, Anna Szonyi, Szabolcs Vasas, and Erzsebet Szilagyi. > > > Bugs: SQOOP-2349 > https://issues.apache.org/jira/browse/SQOOP-2349 > > > Repository: sqoop-trunk > > > Description > ------- > > I've introduced a cmd line parameter for being able to set the metadata transaction levels (defined on java.sql.Connection) manually if necessary. The change is backward compatible, so by default SQOOP gonna still use READ_COMMITTED. > > > Diffs > ----- > > src/java/org/apache/sqoop/SqoopOptions.java e14a0b7 > src/java/org/apache/sqoop/manager/SqlManager.java 768507b > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 13a9697 > src/test/org/apache/sqoop/tool/TestImportTool.java PRE-CREATION > > Diff: https://reviews.apache.org/r/53423/diff/ > > > Testing > ------- > > > Thanks, > > Attila Szabo > > --===============2787292050157413057==--