From dev-return-33138-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Tue Nov 29 18:05:54 2016 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70C8419779 for ; Tue, 29 Nov 2016 18:05:54 +0000 (UTC) Received: (qmail 89227 invoked by uid 500); 29 Nov 2016 18:05:54 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 89200 invoked by uid 500); 29 Nov 2016 18:05:54 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 89185 invoked by uid 500); 29 Nov 2016 18:05:54 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 89177 invoked by uid 99); 29 Nov 2016 18:05:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Nov 2016 18:05:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B9B2C2F71A8; Tue, 29 Nov 2016 18:05:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4250104165897885896==" MIME-Version: 1.0 Subject: Re: Review Request 54168: SQOOP-3057 3rd party Oracle tests are failing From: Attila Szabo To: Szabolcs Vasas , Attila Szabo Cc: Anna Szonyi , Sqoop Date: Tue, 29 Nov 2016 18:05:51 -0000 Message-ID: <20161129180551.5576.77704@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Attila Szabo X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54168/ X-Sender: Attila Szabo X-ReviewBoard-ShipIt: 1 References: <20161129165218.5576.5698@reviews.apache.org> In-Reply-To: <20161129165218.5576.5698@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Attila Szabo X-ReviewRequest-Repository: sqoop-trunk --===============4250104165897885896== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54168/#review157286 ----------------------------------------------------------- Ship it! Ship It! - Attila Szabo On Nov. 29, 2016, 4:52 p.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54168/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 4:52 p.m.) > > > Review request for Sqoop, Attila Szabo and Szabolcs Vasas. > > > Bugs: SQOOP-3057 > https://issues.apache.org/jira/browse/SQOOP-3057 > > > Repository: sqoop-trunk > > > Description > ------- > > 3rd party Oracle tests are failing due to incorrect case of "id" "msg" between verification and table creations (verify needs upper, oracle creates lowercase names). Currently the OracleManagerTest:testOracleImport test is failing as it seems tha passing of timezone is incorrect - it should be fixed in a different JIRA. + Fixed an incorrect import > > > Diffs > ----- > > src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java 2e2448a > src/test/com/cloudera/sqoop/manager/OracleExportTest.java e716510 > src/test/org/apache/sqoop/manager/oracle/OracleCallExportTest.java 431df0f > > Diff: https://reviews.apache.org/r/54168/diff/ > > > Testing > ------- > > ran ant clean test, ant clean test -Dhadoopversion=260 -Dhbaseprofile=95 -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=$3RD_PARTY_LIB -Dmaxmemory=2048m -DtargetJavaVersion=1.7 -DjavaVersion=1.7 -Djava.security.egd=file:///dev/./urandom -Dsqoop.test.oracle.connectstring=$ORACLE_CONN -Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=1000000 -Dtestcase=Oracle*Test > > > Thanks, > > Anna Szonyi > > --===============4250104165897885896==--