-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52212/#review150167
-----------------------------------------------------------
Hey Liz,
Thanks for the contribution I think it can greatly impact the usability by not running into
confusions/wired error messages.
Although I'd like to ask you one additional thing to do:
Could you please add a JUNIT testcase where you test the logic what you'd implemented thus
ensuring we have some safety belt for the future.
One positive and one negative expected behaviour would be fine (+ corner cases like null,
"", etc.)
Could you please add these changes too?
Thanks,
Maugli
- Attila Szabo
On Sept. 23, 2016, 9:38 a.m., Erzsebet Szilagyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52212/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2016, 9:38 a.m.)
>
>
> Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna Szonyi, and
Szabolcs Vasas.
>
>
> Bugs: SQOOP-3013
> https://issues.apache.org/jira/browse/SQOOP-3013
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> When setting job configurations and adding files to "tmpjars", Sqoop does not sanitize
the list of empty strings.
> Sqoop should remove empty strings before starting the MR job and raise a warning if an
empty string was found.
>
> The proposed changes check for empty strings in "tmpjars" and remove them along with
raising a warning.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684ced4c0508e81dfa266998345d8ac5c7d9
>
> Diff: https://reviews.apache.org/r/52212/diff/
>
>
> Testing
> -------
>
> Live test with command including: "tmpjars=,,valid,,,validother,,,"
>
>
> Thanks,
>
> Erzsebet Szilagyi
>
>
|