-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43972/#review121955
-----------------------------------------------------------
Ship it!
I'm overall +1, let's just see what's wrong with the precommit hook.
- Jarek Cecho
On Feb. 29, 2016, 9:36 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43972/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 9:36 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2845
> https://issues.apache.org/jira/browse/SQOOP-2845
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Sqoop2: Derive keystore password from a script passed to configuration
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/security/SecurityConstants.java 91a1b8bb0b4a266381faccd11617bba236c6b446
> server/src/main/java/org/apache/sqoop/server/SqoopJettyServer.java 60368afc0af8b899696476607a5c0bc6d6084794
> server/src/main/java/org/apache/sqoop/server/common/ServerError.java a644e9f10ba792a9c36d5b90db1b5d7f29569e43
> test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java e3fbe315e2b23735e2e31321b038dd88c5f99021
> test/src/test/java/org/apache/sqoop/integration/serverproperties/SslTest.java 17503f3f24ce8344e96e6f7c60085f015eac38f7
>
> Diff: https://reviews.apache.org/r/43972/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Abraham Fine
>
>
|