Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BD5F818D49 for ; Tue, 16 Jun 2015 17:12:38 +0000 (UTC) Received: (qmail 11286 invoked by uid 500); 16 Jun 2015 17:12:38 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 11247 invoked by uid 500); 16 Jun 2015 17:12:38 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 11236 invoked by uid 500); 16 Jun 2015 17:12:38 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 11231 invoked by uid 99); 16 Jun 2015 17:12:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jun 2015 17:12:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 351CC1DFDC9; Tue, 16 Jun 2015 17:12:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5617738050139155451==" MIME-Version: 1.0 Subject: Re: Review Request 35500: hive.metastore.sasl.enabled should be set to true for Oozie integration From: "Abraham Elmahrek" To: "Abraham Elmahrek" , "Qian Xu" , "Sqoop" Date: Tue, 16 Jun 2015 17:12:38 -0000 Message-ID: <20150616171238.1515.60392@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Abraham Elmahrek" X-ReviewGroup: Sqoop X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/35500/ X-Sender: "Abraham Elmahrek" References: <20150616162958.1512.17672@reviews.apache.org> In-Reply-To: <20150616162958.1512.17672@reviews.apache.org> Reply-To: "Abraham Elmahrek" X-ReviewRequest-Repository: sqoop-trunk --===============5617738050139155451== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 16, 2015, 4:29 p.m., Qian Xu wrote: > > src/java/org/apache/sqoop/hive/HiveImport.java, line 332 > > > > > > Generally +1. > > > > One NIT: As the similar code appears twice, do you think if we could have a private method `private String[] getHiveArgs(String... extraArgs)` to create the argument array? Makes sense. Will work with Lists instead though. - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35500/#review88079 ----------------------------------------------------------- On June 16, 2015, 9:57 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35500/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 9:57 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2400 > https://issues.apache.org/jira/browse/SQOOP-2400 > > > Repository: sqoop-trunk > > > Description > ------- > > commit 8102d2445812718c37e6da1976fb1ecc2322a03a > Author: Abraham Elmahrek > Date: Sun May 31 09:52:58 2015 -0700 > > SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration > > :100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java > > > Diffs > ----- > > src/java/org/apache/sqoop/hive/HiveImport.java 097d622 > > Diff: https://reviews.apache.org/r/35500/diff/ > > > Testing > ------- > > Manually > > > Thanks, > > Abraham Elmahrek > > --===============5617738050139155451==--