From dev-return-25402-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Mon Jun 8 13:07:11 2015 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5861184C4 for ; Mon, 8 Jun 2015 13:07:11 +0000 (UTC) Received: (qmail 40145 invoked by uid 500); 8 Jun 2015 13:07:11 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 40114 invoked by uid 500); 8 Jun 2015 13:07:11 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 40103 invoked by uid 500); 8 Jun 2015 13:07:11 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 40098 invoked by uid 99); 8 Jun 2015 13:07:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jun 2015 13:07:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 802FC1DF3AD; Mon, 8 Jun 2015 13:07:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8514962921554721789==" MIME-Version: 1.0 Subject: Re: Review Request 32474: Patch for SQOOP-1809 From: "Abraham Elmahrek" To: "Abraham Elmahrek" , "Veena Basavaraj" , "Sqoop" Date: Mon, 08 Jun 2015 13:07:10 -0000 Message-ID: <20150608130710.27736.22873@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Abraham Elmahrek" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/32474/ X-Sender: "Abraham Elmahrek" References: <20150325032951.1504.64100@reviews.apache.org> In-Reply-To: <20150325032951.1504.64100@reviews.apache.org> Reply-To: "Abraham Elmahrek" X-ReviewRequest-Repository: sqoop-sqoop2 --===============8514962921554721789== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32474/#review87020 ----------------------------------------------------------- I think the TO Job Configuration section is not necessary yet. Let's kill those changes? docs/src/site/sphinx/Connectors.rst Something more human friendly maybe. Your call. docs/src/site/sphinx/Connectors.rst "IncrementalRead" or something more human friendly docs/src/site/sphinx/Connectors.rst "Check column" docs/src/site/sphinx/Connectors.rst " the following..." => ". There are two config lists." docs/src/site/sphinx/Connectors.rst Maybe make a list here? http://docutils.sourceforge.net/docs/user/rst/quickref.html#enumerated-lists docs/src/site/sphinx/Connectors.rst Human readable? docs/src/site/sphinx/Connectors.rst This doesn't actually exist yet. I - Abraham Elmahrek On March 25, 2015, 3:29 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32474/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 3:29 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1809 > https://issues.apache.org/jira/browse/SQOOP-1809 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > doc > > > Diffs > ----- > > docs/src/site/sphinx/Connectors.rst 7b12016 > > Diff: https://reviews.apache.org/r/32474/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > > --===============8514962921554721789==--