sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Elmahrek" <...@cloudera.com>
Subject Re: Review Request 36027: SQOOP-2406: Parquet support in a secure cluster
Date Tue, 30 Jun 2015 01:13:17 GMT


> On June 30, 2015, 12:32 a.m., Ryan Blue wrote:
> > src/java/org/apache/sqoop/mapreduce/ParquetJob.java, line 175
> > <https://reviews.apache.org/r/36027/diff/1/?file=995335#file995335line175>
> >
> >     I know it's a pain, but this should catch the exceptions separately instead
of catching Exception.
> >     
> >     Same for line 205.

Handling would be the same generally since we're just logging the exception.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36027/#review89834
-----------------------------------------------------------


On June 29, 2015, 11:54 p.m., Abraham Elmahrek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36027/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 11:54 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2406
>     https://issues.apache.org/jira/browse/SQOOP-2406
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> commit 3ed86cf1282cd8e3c5f31728d5b15fcb7685a3c1
> Author: Abraham Elmahrek <abe@apache.org\>
> Date:   Fri Jun 19 14:14:13 2015 +0300
> 
>     fetch hive delegation token
> 
>     Kite hive delegation token
> 
> :100644 100644 a665a20... 90d75b3... M  src/docs/user/hive-notes.txt
> :100644 100644 7521464... 997b6be... M  src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java
> :100644 100644 c775ef3... 335d9ff... M  src/java/org/apache/sqoop/mapreduce/ParquetJob.java
> 
> 
> Diffs
> -----
> 
>   src/docs/user/hive-notes.txt a665a20 
>   src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 7521464 
>   src/java/org/apache/sqoop/mapreduce/ParquetJob.java c775ef3 
> 
> Diff: https://reviews.apache.org/r/36027/diff/
> 
> 
> Testing
> -------
> 
> Manually tested with oozie and on CLI.
> 
> 
> Thanks,
> 
> Abraham Elmahrek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message