Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 47FE717DCB for ; Mon, 23 Mar 2015 14:55:11 +0000 (UTC) Received: (qmail 55205 invoked by uid 500); 23 Mar 2015 14:55:11 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 55169 invoked by uid 500); 23 Mar 2015 14:55:11 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 55154 invoked by uid 99); 23 Mar 2015 14:55:11 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Mar 2015 14:55:11 +0000 Date: Mon, 23 Mar 2015 14:55:11 +0000 (UTC) From: "Veena Basavaraj (JIRA)" To: dev@sqoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SQOOP-2113) Modify REST API for the RU operation on job and link config MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SQOOP-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14375993#comment-14375993 ] Veena Basavaraj edited comment on SQOOP-2113 at 3/23/15 2:54 PM: ----------------------------------------------------------------- I thought it was obvious from the prev message, but here is the detailed explanation. Initially a value of s config may be null, for instance the case of state variable generated in the connector. A user might want to edit them to add a value and this will throw an exception since the record wont even exist, but when then fetch the configs via the link or job command, they will get all the configs, even with null values in the list. So it is misleading. Secondly if a config input is declared for a link or job config, unless the field says not nullable, a user should be able to store "null" for it and then use that value. It is semantically correct. Some of the integration tests were failing "with my patch because I did not realize that we were not honoring this aspect. Hope this explains. was (Author: vybs): I thought it was obvious from the prev message, but here is the detailed explanation. Initially a value of s config may be null, for instance the case of state variable generated in the connector. A user might want to edit them to add a value and this will throw an exception since the record wont even exist, but when then fetch the configs via the link or job command, they will get all the configs, even with null values in the list. So it is misleading. Secondly if a config input is declared for a link or job config, unless the field says not nullable, a user should be able to store "null" for it and then use that value. It is semantically correct. Some of the integration tests were failing because I did not realize that we were not honoring this aspect. Hope this explains. > Modify REST API for the RU operation on job and link config > ----------------------------------------------------------- > > Key: SQOOP-2113 > URL: https://issues.apache.org/jira/browse/SQOOP-2113 > Project: Sqoop > Issue Type: Bug > Reporter: Veena Basavaraj > Assignee: Veena Basavaraj > Fix For: 1.99.6 > > Attachments: SQOOP-2113-1.patch, SQOOP-2113-1.patch, SQOOP-2113-2.patch > > > based on the design doc for 1516, support the RU operation on configs for rest -- This message was sent by Atlassian JIRA (v6.3.4#6332)