Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E66CE10D55 for ; Sat, 21 Mar 2015 16:58:14 +0000 (UTC) Received: (qmail 71292 invoked by uid 500); 21 Mar 2015 16:58:14 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 71255 invoked by uid 500); 21 Mar 2015 16:58:14 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 71242 invoked by uid 500); 21 Mar 2015 16:58:14 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 71232 invoked by uid 99); 21 Mar 2015 16:58:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Mar 2015 16:58:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 759E71D466E; Sat, 21 Mar 2015 16:58:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5843739092255897871==" MIME-Version: 1.0 Subject: Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for sentry authorization From: "Prasad Mujumdar" To: "Abraham Elmahrek" , "Dapeng Sun" , "Prasad Mujumdar" , "Colin Ma" , "Xiaomeng Huang" Cc: "shen guoquan" , "sentry" , "Sqoop" Date: Sat, 21 Mar 2015 16:58:13 -0000 Message-ID: <20150321165813.1490.72798@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Prasad Mujumdar" X-ReviewGroup: sentry, Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/31617/ X-Sender: "Prasad Mujumdar" References: <20150318020239.391.12939@reviews.apache.org> In-Reply-To: <20150318020239.391.12939@reviews.apache.org> Reply-To: "Prasad Mujumdar" X-ReviewRequest-Repository: sentry --===============5843739092255897871== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31617/#review77334 ----------------------------------------------------------- Looks fine overall. A few comments/suggestions below. sentry-policy/sentry-policy-sqoop/pom.xml Nit: Do we need to specify version here ? sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java I think we should add a warning that db provider is the preferred option over file. sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java It should check that the exception is actually authorization exception so that other unexpected errors won't go unnoticed. sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java Nit: It would be nice if these are defined as constants. sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java It would be good add some negative scenarios for analyst and developer roles. sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java Do we need this to be a new class in sqoop package ? If this is direct copy/paste from other modules, would be it be possible to move these common helper classes to a new test-common module ? - Prasad Mujumdar On March 18, 2015, 2:02 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31617/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 2:02 a.m.) > > > Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton > > > Diffs > ----- > > pom.xml 4c80916 > sentry-dist/pom.xml f63b33b > sentry-policy/pom.xml 4fb4f3c > sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION > > Diff: https://reviews.apache.org/r/31617/diff/ > > > Testing > ------- > > Ran the unit tests. > > > Thanks, > > shen guoquan > > --===============5843739092255897871==--