From dev-return-22751-apmail-sqoop-dev-archive=sqoop.apache.org@sqoop.apache.org Wed Mar 4 16:51:38 2015 Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2FEEC17AB9 for ; Wed, 4 Mar 2015 16:51:38 +0000 (UTC) Received: (qmail 56741 invoked by uid 500); 4 Mar 2015 16:51:35 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 56708 invoked by uid 500); 4 Mar 2015 16:51:35 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 56695 invoked by uid 500); 4 Mar 2015 16:51:34 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 56688 invoked by uid 99); 4 Mar 2015 16:51:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2015 16:51:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AD1001CBFDD; Wed, 4 Mar 2015 16:51:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1643155878669971785==" MIME-Version: 1.0 Subject: Review Request 31728: SQOOP-2170 MySQL specific tests are not properly cleaning up created tables From: "Jarek Cecho" To: "Sqoop" , "Jarek Cecho" Date: Wed, 04 Mar 2015 16:51:33 -0000 Message-ID: <20150304165133.12263.13828@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jarek Cecho" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/31728/ X-Sender: "Jarek Cecho" Reply-To: "Jarek Cecho" X-ReviewRequest-Repository: sqoop-trunk --===============1643155878669971785== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31728/ ----------------------------------------------------------- Review request for Sqoop. Repository: sqoop-trunk Description ------- I found the current MySQL tests a bit messy - there is a lot of copy&pasted code around. As MySQL tests are extending normal HSQLDB tests, I did not wanted to completely refactore them as that would be quite intrusive change. Instead I've chosen approach of ensuring that each test is simply cleaning up the tables properly - this means that I've put a lot of similar code to all MySQL tests. Whereas not perfect, this have been intentional at the moment. Diffs ----- src/test/com/cloudera/sqoop/TestAllTables.java d2c7b16 src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java eac7836 src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java b7d6284 src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java f7cc297 src/test/org/apache/sqoop/manager/mysql/MySqlCallExportTest.java 3be447e Diff: https://reviews.apache.org/r/31728/diff/ Testing ------- I've run all the affected tests, they are passing and are properly cleaning up the testing tables. Thanks, Jarek Cecho --===============1643155878669971785==--