sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for sentry authorization
Date Sat, 21 Mar 2015 16:58:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review77334
-----------------------------------------------------------


Looks fine overall. A few comments/suggestions below.


sentry-policy/sentry-policy-sqoop/pom.xml
<https://reviews.apache.org/r/31617/#comment125245>

    Nit: Do we need to specify version here ?



sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java
<https://reviews.apache.org/r/31617/#comment125249>

    I think we should add a warning that db provider is the preferred option over file.



sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java
<https://reviews.apache.org/r/31617/#comment125250>

    It should check that the exception is actually  authorization exception so that other
unexpected errors won't go unnoticed.



sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java
<https://reviews.apache.org/r/31617/#comment125248>

    Nit: It would be nice if these are defined as constants.



sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java
<https://reviews.apache.org/r/31617/#comment125251>

    It would be good add some negative scenarios for analyst and developer roles.



sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java
<https://reviews.apache.org/r/31617/#comment125252>

    Do we need this to be a new class in sqoop package ? If this is direct copy/paste from
other modules, would be it be possible to move these common helper classes to a new test-common
module ?


- Prasad Mujumdar


On March 18, 2015, 2:02 a.m., shen guoquan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 2:02 a.m.)
> 
> 
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng
Sun, and Prasad Mujumdar.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
> 
> 
> Diffs
> -----
> 
>   pom.xml 4c80916 
>   sentry-dist/pom.xml f63b33b 
>   sentry-policy/pom.xml 4fb4f3c 
>   sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java
PRE-CREATION 
>   sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION

>   sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/31617/diff/
> 
> 
> Testing
> -------
> 
> Ran the unit tests.
> 
> 
> Thanks,
> 
> shen guoquan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message