sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Jarcec Cecho (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1836) Convert the List in Schema Columns to Array for better lookup time
Date Wed, 03 Dec 2014 17:21:13 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233207#comment-14233207
] 

Jarek Jarcec Cecho commented on SQOOP-1836:
-------------------------------------------

I would probably keep the schema as {{List}} inside the {{Schema}} class as we're usually
building the schema iteratively. Let's perhaps convert it to Array when returning back to
the user?

> Convert the List in Schema Columns to Array for better lookup time
> ------------------------------------------------------------------
>
>                 Key: SQOOP-1836
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1836
>             Project: Sqoop
>          Issue Type: Sub-task
>          Components: sqoop2-framework
>            Reporter: Veena Basavaraj
>              Labels: newbie
>             Fix For: 1.99.5
>
>
> see comments in the https://reviews.apache.org/r/28636/
> Most times we will need to index the column array when extracting and loading. So it
is good perf improvement to store it as array as per [~jarcec]
> https://github.com/apache/sqoop/blob/sqoop2/common/src/main/java/org/apache/sqoop/schema/Schema.java#L62
> Clean up all places where toArray is done and move this to this to the Schema class itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message