sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Veena Basavaraj <vbasava...@cloudera.com>
Subject Re: Sqoop 2 JAVA coding guidelines
Date Mon, 01 Dec 2014 02:29:20 GMT
Qian,

I think we both are on the same page.

I just wrote the guidelines wiki to to come up with the code style.

One we all vote on the wiki, we can formulate those rules as IDE specific
files, like the one you attached for intelliJ

Hope it clears the confusion now.




Best,
*./Vee*

On Sun, Nov 30, 2014 at 6:20 PM, Xu, Qian A <qian.a.xu@intel.com> wrote:

> Hi Veena,
>
> A code guideline will definitively help both developers and reviews to
> contribute code better. I'd suggest apply code style to new code
> contribution first.
>
> --Qian (Stanley) Xu
>
> -----Original Message-----
> From: Veena Basavaraj [mailto:vbasavaraj@cloudera.com]
> Sent: Monday, December 01, 2014 10:09 AM
> To: dev@sqoop.apache.org
> Subject: Re: Sqoop 2 JAVA coding guidelines
>
> Thanks Qian, I will attach it, do you have any comments on the guidelines?
> We should all vote for the wiki guidelines before we attach the formatter.
>
> Please send an email to the dev@ list asking permission to edit the wiki.
>
>
>
>
> Best,
> *./Vee*
>
> On Sun, Nov 30, 2014 at 5:59 PM, Xu, Qian A <qian.a.xu@intel.com> wrote:
>
> > Hi there.
> >
> > I don’t have the privilege to add attachment to Wiki , so I've
> > attached code formatter of IntelliJ (v13.1). I hope this helps.
> >
> > --Qian (Stanley) Xu
> >
> >
> > -----Original Message-----
> > From: Gwen Shapira [mailto:gshapira@cloudera.com]
> > Sent: Monday, December 01, 2014 8:46 AM
> > To: dev@sqoop.apache.org
> > Subject: Re: Sqoop 2 JAVA coding guidelines
> >
> > I think its a great idea to document the coding standards that already
> > exist for this project.
> > It can be frustrating to new contributors to have to guess their way
> > around our un-written expectations.
> >
> > Gwen
> >
> > On Sun, Nov 30, 2014 at 2:05 PM, Veena Basavaraj
> > <vbasavaraj@cloudera.com>
> > wrote:
> > > Hey all,
> > >
> > > Since a few months I have been contributing to Sqoop2, I do notice a
> > > lack of style guide for sqoop2 code.
> > >
> > > I have started a wiki highlighting things for developers to follow.
> > >
> > > https://cwiki.apache.org/confluence/display/SQOOP/Sqoop+2+Coding+Gui
> > > de lines I prefer the google java style guide to begin with.
> > >
> > > Please add your comments in the comments section on things you would
> > > like to have, so we can iterate over this in the coming few weeks
> > > and settle down to a standard that every one can use in their IDE. I
> > > am happy to create a formatter XML for eclipse as per these rules
> > > and attach it to the wiki.
> > >
> > >
> > >
> > > Best,
> > > *./Vee*
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message