Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E1A27175DF for ; Tue, 7 Oct 2014 06:30:10 +0000 (UTC) Received: (qmail 7597 invoked by uid 500); 7 Oct 2014 06:30:10 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 7559 invoked by uid 500); 7 Oct 2014 06:30:10 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 7545 invoked by uid 500); 7 Oct 2014 06:30:10 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 7539 invoked by uid 99); 7 Oct 2014 06:30:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Oct 2014 06:30:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A31C71DDCDF; Tue, 7 Oct 2014 06:30:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8262264685965794720==" MIME-Version: 1.0 Subject: Re: Review Request 26295: SQOOP-1477: Sqoop2: Make link and job name unique identifier From: "Abraham Elmahrek" To: "Abraham Elmahrek" , "Veena Basavaraj" , "Sqoop" , "Gwen Shapira" Date: Tue, 07 Oct 2014 06:30:06 -0000 Message-ID: <20141007063006.24817.34578@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Abraham Elmahrek" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/26295/ X-Sender: "Abraham Elmahrek" References: <20141003215315.19177.6302@reviews.apache.org> In-Reply-To: <20141003215315.19177.6302@reviews.apache.org> Reply-To: "Abraham Elmahrek" X-ReviewRequest-Repository: sqoop-SQOOP-1367 --===============8262264685965794720== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 3, 2014, 9:53 p.m., Veena Basavaraj wrote: > > core/src/main/java/org/apache/sqoop/repository/RepositoryError.java, line 124 > > > > > > I am becoming more picky about everthing! > > > > these should say invalid linf configs/ job configs for connector. Please I've rebased and most of these were picked up! - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26295/#review55403 ----------------------------------------------------------- On Oct. 6, 2014, 11:10 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26295/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 11:10 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1477 > https://issues.apache.org/jira/browse/SQOOP-1477 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit 450db6146922bc197bb7c3eda375319788d610ba > Author: Abraham Elmahrek > Date: Thu Oct 2 16:19:21 2014 -0700 > > SQOOP-1477: Sqoop2: Make link and job name unique identifier > > :100644 100644 3466116... e7d4589... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > :100644 100644 a743491... 792306e... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > :100644 100644 54e37d9... 2489c58... M core/src/main/java/org/apache/sqoop/repository/RepositoryError.java > :100644 100644 19b0023... e9a6075... M core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > :100644 100644 5dd7970... 1ea388f... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 ad42901... d38d789... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 54e37d9 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 39702ca > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java fc3ec18 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java 951d9b4 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java bf72626 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java 1292168 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 595b1c8 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 38e632a > > Diff: https://reviews.apache.org/r/26295/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Abraham Elmahrek > > --===============8262264685965794720==--