Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC31E179B1 for ; Fri, 3 Oct 2014 18:26:47 +0000 (UTC) Received: (qmail 48806 invoked by uid 500); 3 Oct 2014 18:26:47 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 48774 invoked by uid 500); 3 Oct 2014 18:26:47 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 48728 invoked by uid 500); 3 Oct 2014 18:26:47 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 48723 invoked by uid 99); 3 Oct 2014 18:26:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Oct 2014 18:26:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 091F01DDC3A; Fri, 3 Oct 2014 18:26:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5236327295804547276==" MIME-Version: 1.0 Subject: Re: Review Request 26295: SQOOP-1477: Sqoop2: Make link and job name unique identifier From: "Abraham Elmahrek" To: "Abraham Elmahrek" , "Veena Basavaraj" , "Sqoop" Date: Fri, 03 Oct 2014 18:26:44 -0000 Message-ID: <20141003182644.18846.51708@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Abraham Elmahrek" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/26295/ X-Sender: "Abraham Elmahrek" References: <20141002235203.18846.76474@reviews.apache.org> In-Reply-To: <20141002235203.18846.76474@reviews.apache.org> Reply-To: "Abraham Elmahrek" X-ReviewRequest-Repository: sqoop-SQOOP-1367 --===============5236327295804547276== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 2, 2014, 11:52 p.m., Veena Basavaraj wrote: > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java, line 1254 > > > > > > these 2 mthods are the same, existLink/Job exvept the sql query, lets please create one method to reuse it. > > > > I am not sure the apis should be public at all, why ? These don't exist any more in this patch. > On Oct. 2, 2014, 11:52 p.m., Veena Basavaraj wrote: > > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java, line 214 > > > > > > why public? I dont think we need to expose it. These don't exist any more in this patch. - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26295/#review55284 ----------------------------------------------------------- On Oct. 3, 2014, 4:06 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26295/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 4:06 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1477 > https://issues.apache.org/jira/browse/SQOOP-1477 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > commit 450db6146922bc197bb7c3eda375319788d610ba > Author: Abraham Elmahrek > Date: Thu Oct 2 16:19:21 2014 -0700 > > SQOOP-1477: Sqoop2: Make link and job name unique identifier > > :100644 100644 3466116... e7d4589... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > :100644 100644 a743491... 792306e... M core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > :100644 100644 54e37d9... 2489c58... M core/src/main/java/org/apache/sqoop/repository/RepositoryError.java > :100644 100644 19b0023... e9a6075... M core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > :100644 100644 5dd7970... 1ea388f... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 ad42901... d38d789... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/repository/RepositoryError.java 54e37d9 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java 5dd7970 > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 58eed2d > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java ad42901 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 4b95687 > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java 47350ea > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java 8dd1ce2 > > Diff: https://reviews.apache.org/r/26295/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Abraham Elmahrek > > --===============5236327295804547276==--