sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Veena Basavaraj (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1638) Notification on Submission.
Date Fri, 31 Oct 2014 23:26:33 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192732#comment-14192732
] 

Veena Basavaraj commented on SQOOP-1638:
----------------------------------------

I see thanks for the info. I would like to document this somewhere 

it is a call back URL,  Since it is not an external api. we can have a way not to expose this
to the user

I will take this ticket up separately to support this in a better way

We dont even log the status in the logs. I dont see any persistence, does status method modify
the record? It is more like update Status .

> Notification on Submission.
> ---------------------------
>
>                 Key: SQOOP-1638
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1638
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 2.0.0
>
>
> What is this really supposed to do?
> There was some hacky code to set this URL
> {code}
> // TODO: This should be outsourced somewhere more suitable than here
>         if(JobManager.getInstance().getNotificationBaseUrl() == null) {
>           String url = ctx.getRequest().getRequestURL().toString();
>           JobManager.getInstance().setNotificationBaseUrl(
>             url.split("v1")[0] + "/v1/submission/notification/");
>         }
> {code}
> But all it did was return status
> {code}
>   private JsonBean handleNotification(RequestContext ctx, String sjid) {
>     LOG.debug("Received notification request for job " + sjid);
>     JobManager.getInstance().status(Long.parseLong(sjid));
>     return JsonBean.EMPTY_BEAN;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message