sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-1439) Sqoop2: Refactor validations
Date Tue, 28 Oct 2014 18:39:33 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187249#comment-14187249
] 

ASF subversion and git services commented on SQOOP-1439:
--------------------------------------------------------

Commit a203e77264d2ba89b962c38baf10bceead06877e in sqoop's branch refs/heads/sqoop2 from [~abec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=a203e77 ]

SQOOP-1439: Sqoop2: Validations: Remove all references to the original Validation infastructure

(Jarek Jarcec Cecho via Abraham Elmahrek)


> Sqoop2: Refactor validations
> ----------------------------
>
>                 Key: SQOOP-1439
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1439
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: from/to
>
>
> On my quest to fix technical depth that I've myself put into Sqoop2, I would like to
propose refactoring validator interface. The problems that I see:
> * Validations are *ONLY* server side, client has to always go to the sever to validate
everything. Whereas some validations can never be executed to client, it would be nice to
give client opportunity to run at least some basic validations.
> * Validations are in separate {{Validator}} class and are completely separate from the
actual configuration objects. This makes the development quite hard and "disconnected".
> * Entire interface is very non-intuitive as one has to call methods where parameters
are names of instance variables which is awful and don't provide any level of checking that
you've set validation on the correct object.
> I would like to move the validations to annotations so that validation and given configuration
object are in the same place. This will also allow us to serialize and send them to the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message