sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 27360: SQOOP-1645:Update label text and (optional) required info for the generic jdbc connector config properties
Date Thu, 30 Oct 2014 14:34:12 GMT


> On Oct. 30, 2014, 1:32 a.m., Jarek Cecho wrote:
> > I think that this patch needs a rebase on HEAD of current sqoop2 branch, I'm getting
compilation error:
> > 
> > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile
(default-compile) on project sqoop-connector-generic-jdbc: Compilation failure
> > [ERROR] /Users/jarcec/apache/sqoop2-vanila/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java:[96,33]
cannot find symbol
> > 
> > I've removed the GenericJdbcValidator class recently.
> 
> Veena Basavaraj wrote:
>     I had rebased before and did once more. I am not sure why it is failing. the SQOOP
bot seems to be fine 4 hours ago as well
>     
>     Sqoop QA bot added a comment - 4 hours ago
>     Here are the results of testing the latest attachment
>     https://issues.apache.org/jira/secure/attachment/12678068/SQOOP-1645.patch against
branch sqoop2.
>     Overall: +1 all checks pass
>     SUCCESS: Clean was successful
>     SUCCESS: Patch applied correctly
>     SUCCESS: Patch add/modify test case
>     SUCCESS: Patch compiled
>     SUCCESS: All tests passed
>     Console output: https://builds.apache.org/job/PreCommit-SQOOP-Build/491/console
>     This message is automatically generated.

Must have been something local on my side as it seems to be working now, sorry for the false
alarm.


- Jarek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27360/#review59103
-----------------------------------------------------------


On Oct. 30, 2014, 4:23 a.m., Veena Basavaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27360/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 4:23 a.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
1747347 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java
12ceb21 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java
2428601 
>   connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties
c535e9b 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
243de01 
> 
> Diff: https://reviews.apache.org/r/27360/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Veena Basavaraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message