Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C4F42113E0 for ; Tue, 2 Sep 2014 06:49:22 +0000 (UTC) Received: (qmail 8650 invoked by uid 500); 2 Sep 2014 06:49:21 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 8625 invoked by uid 500); 2 Sep 2014 06:49:21 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 8596 invoked by uid 99); 2 Sep 2014 06:49:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Sep 2014 06:49:21 +0000 Date: Tue, 2 Sep 2014 06:49:21 +0000 (UTC) From: "Jarek Jarcec Cecho (JIRA)" To: dev@sqoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SQOOP-1395) Use random generated class name for SqoopRecord MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SQOOP-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117949#comment-14117949 ] Jarek Jarcec Cecho commented on SQOOP-1395: ------------------------------------------- I'm concerned about randomizing the class name as that is backward incompatible change that can break existing users especially when importing into Sequence Files where the class name is very important. Additionally, user can override the generated class name via {{\-\-class\-name}} parameter anyway, so I don't think that randomizing is a valid solution as it will either break the parameter or won't solve the problem. If Kite is trying to instantiate a class based on some Avro schema flag, I'm wondering if it would be easier to change the flag? For example to put some prefix there or use different property alltogether? > Use random generated class name for SqoopRecord > ----------------------------------------------- > > Key: SQOOP-1395 > URL: https://issues.apache.org/jira/browse/SQOOP-1395 > Project: Sqoop > Issue Type: Sub-task > Components: tools > Reporter: Qian Xu > Assignee: Qian Xu > Priority: Minor > Attachments: SQOOP-1395.patch > > > Sqoop will generate an entity class to hold values of every database record for mapreduce. The class is inherited from the abstract class SqoopRecord. The name of the class is by default the table name. > When export records as Parquet files, the internal logic will attempt to instantiate another entity class or create it on demand. Unfortunately, the target class has the same name of the one Sqoop generated. > The JIRA propose to use random class name to avoid the potential problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)