sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Xu" <sx.a...@googlemail.com>
Subject Review Request 25326: SQOOP-1491: Refactoring AvroUtil and SqoopAvroRecord
Date Thu, 04 Sep 2014 04:36:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25326/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1491
    https://issues.apache.org/jira/browse/SQOOP-1491


Repository: sqoop-trunk


Description
-------

This is a patch to SQOOP-1395. As the entity class name is no longer identical to the record
name in Avro schema, there is not need to have SqoopAvroRecord. The patch proposes to do two
things:
1. Remove SqoopAvroRecord
2. Move common Avro handling code to AvtoUtil


Diffs
-----

  src/java/org/apache/sqoop/avro/AvroUtil.java 4b37d58 
  src/java/org/apache/sqoop/lib/SqoopAvroRecord.java 80875d2 
  src/java/org/apache/sqoop/mapreduce/AvroImportMapper.java 6adad79 
  src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 905ba8c 
  src/java/org/apache/sqoop/mapreduce/ParquetImportMapper.java effbadd 
  src/java/org/apache/sqoop/mapreduce/ParquetJob.java a74432a 
  src/java/org/apache/sqoop/orm/ClassWriter.java 4f9dedd 

Diff: https://reviews.apache.org/r/25326/diff/


Testing
-------

All unittests passed. No new unittest added.
Manually tested couple of import tests.


Thanks,

Qian Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message