Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3AA75D64D for ; Fri, 30 Nov 2012 00:42:30 +0000 (UTC) Received: (qmail 14559 invoked by uid 500); 30 Nov 2012 00:42:30 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 14469 invoked by uid 500); 30 Nov 2012 00:42:30 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 14459 invoked by uid 500); 30 Nov 2012 00:42:30 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 14452 invoked by uid 99); 30 Nov 2012 00:42:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Nov 2012 00:42:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C195A1C4E72; Fri, 30 Nov 2012 00:42:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7625011721712505976==" MIME-Version: 1.0 Subject: Re: Review Request: SQOOP-728 Increase varchar limits for external link and exceptions in Derby repository From: "Bilung Lee" To: "Bilung Lee" , "Sqoop" , "Jarek Cecho" Date: Fri, 30 Nov 2012 00:42:25 -0000 Message-ID: <20121130004225.21810.13938@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bilung Lee" X-ReviewGroup: Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/8257/ X-Sender: "Bilung Lee" References: <20121129005151.22473.28408@reviews.apache.org> In-Reply-To: <20121129005151.22473.28408@reviews.apache.org> Reply-To: "Bilung Lee" --===============7625011721712505976== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8257/#review13879 ----------------------------------------------------------- Ship it! Ship It! - Bilung Lee On Nov. 29, 2012, 12:51 a.m., Jarek Cecho wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8257/ > ----------------------------------------------------------- > = > (Updated Nov. 29, 2012, 12:51 a.m.) > = > = > Review request for Sqoop. > = > = > Description > ------- > = > I've increased the size of those three columns in submission table and ma= de sure that we won't be saving longer strings. > = > = > This addresses bug SQOOP-728. > https://issues.apache.org/jira/browse/SQOOP-728 > = > = > Diffs > ----- > = > repository/repository-derby/src/main/java/org/apache/sqoop/repository/d= erby/DerbySchemaQuery.java 55d7128 = > = > Diff: https://reviews.apache.org/r/8257/diff/ > = > = > Testing > ------- > = > Unit tests are passing and tested on real cluster. > = > = > Thanks, > = > Jarek Cecho > = > --===============7625011721712505976==--