-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8195/#review13833
-----------------------------------------------------------
Look good overall. One nit. There are quite a few checkstyle violations. Could you please
fix them? Thanks.
- Bilung Lee
On Nov. 23, 2012, 6:59 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8195/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2012, 6:59 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've ported newest implementation of CombineFileInputFormat from Hadoop 2.0.2-alpha.
>
>
> This addresses bug SQOOP-721.
> https://issues.apache.org/jira/browse/SQOOP-721
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/mapreduce/CombineFileInputFormat.java 4f58d7d89cfc2827f9f50e169751cc3cdaf52308
> src/java/org/apache/sqoop/mapreduce/CombineFileRecordReader.java 6f9864b8bcfb28121dc432e62197f259650eceb0
> src/java/org/apache/sqoop/mapreduce/CombineFileSplit.java 8cf4d54cc3a2e77de37734bf4f687f31c32b6e85
>
> Diff: https://reviews.apache.org/r/8195/diff/
>
>
> Testing
> -------
>
> I've done extensive testing on Hadoop 1.x, 2.x and 0.20.
>
>
> Thanks,
>
> Jarek Cecho
>
>
|