Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4DE7C9289 for ; Tue, 3 Apr 2012 20:53:07 +0000 (UTC) Received: (qmail 94503 invoked by uid 500); 3 Apr 2012 20:53:07 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 94427 invoked by uid 500); 3 Apr 2012 20:53:07 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 94417 invoked by uid 500); 3 Apr 2012 20:53:07 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 94407 invoked by uid 99); 3 Apr 2012 20:53:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2012 20:53:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 83BAF1C3ADA; Tue, 3 Apr 2012 20:53:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9028862272472622288==" MIME-Version: 1.0 Subject: Re: Review Request: Patch for SQOOP-474 From: "Cheolsoo Park" To: "Arvind Prabhakar" Date: Tue, 03 Apr 2012 20:53:06 -0000 Message-ID: <20120403205306.8078.54305@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4614/ Cc: "Kathleen Ting" , "Sqoop" , "Cheolsoo Park" In-Reply-To: <20120402222354.8078.90475@reviews.apache.org> References: <20120402222354.8078.90475@reviews.apache.org> --===============9028862272472622288== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4614/#review6664 ----------------------------------------------------------- Hi Kate, your patch looks good. I only want to mention that I made some cha= nge to the same area of code at SQOOP-468, which Jarec is going to submit s= oon. So you will need to rebase your patch once it is committed. In my patch, I factored out that area of code into a separate function (bui= ldBoundaryQuery). To achieve what you're doing here, you can change the fol= lowing line: private String buildBoundaryQuery(String col, String query) { if (col =3D=3D null) { // change to --> if (col =3D=3D null || options= .getNumMappers() =3D=3D 1) { return ""; } ... } I have tested this in my workspace by myself and seen no issues. Please let= me know if you have any concerns/questions. - Cheolsoo On 2012-04-02 22:23:54, Kathleen Ting wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4614/ > ----------------------------------------------------------- > = > (Updated 2012-04-02 22:23:54) > = > = > Review request for Sqoop and Arvind Prabhakar. > = > = > Summary > ------- > = > Before triggering the bounding value query construction, in addition to c= hecking that the user has specified a split by option, also take into accou= nt that the number of mappers is 1. > = > = > This addresses bug SQOOP-474. > https://issues.apache.org/jira/browse/SQOOP-474 > = > = > Diffs > ----- > = > ./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1308530 = > = > Diff: https://reviews.apache.org/r/4614/diff > = > = > Testing > ------- > = > Ran unit tests. Confirmed that, with the fix, the console output does not= have the boundary query in it (i.e. INFO db.DataDrivenDBInputFormat: Bound= ingValsQuery). > = > = > Thanks, > = > Kathleen > = > --===============9028862272472622288==--