Return-Path: X-Original-To: apmail-sqoop-dev-archive@www.apache.org Delivered-To: apmail-sqoop-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ADDF1993E for ; Tue, 3 Apr 2012 19:36:05 +0000 (UTC) Received: (qmail 48755 invoked by uid 500); 3 Apr 2012 19:36:05 -0000 Delivered-To: apmail-sqoop-dev-archive@sqoop.apache.org Received: (qmail 48710 invoked by uid 500); 3 Apr 2012 19:36:05 -0000 Mailing-List: contact dev-help@sqoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sqoop.apache.org Delivered-To: mailing list dev@sqoop.apache.org Received: (qmail 48700 invoked by uid 500); 3 Apr 2012 19:36:05 -0000 Delivered-To: apmail-incubator-sqoop-dev@incubator.apache.org Received: (qmail 48693 invoked by uid 99); 3 Apr 2012 19:36:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2012 19:36:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D846F1C3ADA; Tue, 3 Apr 2012 19:36:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2274761409126026167==" MIME-Version: 1.0 Subject: Re: Review Request: SQOOP-468 Oracle free form queries fail From: "Jarek Cecho" To: "Jarek Cecho" Date: Tue, 03 Apr 2012 19:36:04 -0000 Message-ID: <20120403193604.4079.90095@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4621/ Cc: "Sqoop" , "Cheolsoo Park" In-Reply-To: <20120403193416.8078.89822@reviews.apache.org> References: <20120403193416.8078.89822@reviews.apache.org> --===============2274761409126026167== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2012-04-03 19:34:16, Jarek Cecho wrote: > > Hi Cheolsoo, > > your changes looks good to me. > > = > > Jarcec Please attach your patch to the JIRA and I'll commit it. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4621/#review6661 ----------------------------------------------------------- On 2012-04-03 06:47:20, Cheolsoo Park wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4621/ > ----------------------------------------------------------- > = > (Updated 2012-04-03 06:47:20) > = > = > Review request for Sqoop and Jarek Cecho. > = > = > Summary > ------- > = > Sqoop free-form query import does not work with Oracle, MySQL, and Hsqldb. > = > https://issues.apache.org/jira/browse/SQOOP-468 > = > The changes include: > 1) Use alias 't1' instead of table name in the qualified names. > 2) Add 3 unit tests for Hsqldb, MySQL, and Oracle. > = > = > This addresses bug SQOOP-468. > https://issues.apache.org/jira/browse/SQOOP-468 > = > = > Diffs > ----- > = > /src/test/com/cloudera/sqoop/manager/OracleFreeFormQueryTest.java PRE-C= REATION = > /src/test/com/cloudera/sqoop/manager/MySQLFreeFormQueryTest.java PRE-CR= EATION = > /src/test/com/cloudera/sqoop/TestFreeFormQueryImport.java PRE-CREATION = > /src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1308555 = > = > Diff: https://reviews.apache.org/r/4621/diff > = > = > Testing > ------- > = > 1) The new tests verify that import with a simple free-form query that in= cludes join works with 3 different DBs. > 2) ant test, ant test -Dthirdparty=3Dtrue, and ant checkstyle > = > = > Thanks, > = > Cheolsoo > = > --===============2274761409126026167==--