sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request: SQOOP-453 Oozie does not work with Sqoop metastore
Date Wed, 25 Apr 2012 13:11:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4858/#review7212
-----------------------------------------------------------

Ship it!


Hi Cheolsoo,
change seems fine to me. I've noticed that you've already attached patch to the JIRA, so I'll
commit it shortly.

Jarcec

- Jarek


On 2012-04-24 20:26:31, Cheolsoo Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4858/
> -----------------------------------------------------------
> 
> (Updated 2012-04-24 20:26:31)
> 
> 
> Review request for Sqoop, Jarek Cecho and Kathleen Ting.
> 
> 
> Summary
> -------
> 
> Sqoop metastore jobs cannot be launched via Oozie when sqoop.metastore.client.record.password
disabled.
> 
> The changes include:
> 1) Print out informative error message.
> 2) Add a note to user doc.
> 
> 
> This addresses bug SQOOP-453.
>     https://issues.apache.org/jira/browse/SQOOP-453
> 
> 
> Diffs
> -----
> 
>   /src/docs/user/saved-jobs.txt 1329854 
>   /src/java/org/apache/sqoop/SqoopOptions.java 1329854 
> 
> Diff: https://reviews.apache.org/r/4858/diff
> 
> 
> Testing
> -------
> 
> Manually verified the following cases:
> 
> 1) sqoop.metastore.client.record.password = false && --password is NOT given
in the command tag
> => Jobs fail with the error message in task logs.
> 
> 2) sqoop.metastore.client.record.password = false && --password is given in the
command tag
> => Jobs succeed.
> 
> 3) sqoop.metastore.client.record.password = true
> => Jobs succeed.
> 
> I also ran ant test and ant checkstyle.
> 
> 
> Thanks,
> 
> Cheolsoo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message