sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-467 Add support for Oracle BINARY_FLOAT and BINARY_DOUBLE data types
Date Thu, 05 Apr 2012 04:30:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4641/
-----------------------------------------------------------

(Updated 2012-04-05 04:30:35.627666)


Review request for Sqoop.


Changes
-------

Simplify tests.


Summary
-------

Sqoop import does not support BINARY_FLOAT and BINARY_DOUBLE for Oracle db.

The patch includes:
1) Map BINARY_FLOAT and BINARY_DOUBLE to Java float and double for Oracle.
2) Add test cases to OracleCompatTest to verify the mapping.


This addresses bug SQOOP-467.
    https://issues.apache.org/jira/browse/SQOOP-467


Diffs (updated)
-----

  /src/java/org/apache/sqoop/manager/OracleManager.java 1309536 
  /src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1309536 

Diff: https://reviews.apache.org/r/4641/diff


Testing
-------

1) Verified with Oracle XE 10g that new tests pass.
2) Ran ant test, ant test -Dthirdparty=true, and ant checkstyle.


Thanks,

Cheolsoo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message