sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Review Request: SQOOP-468 Oracle free form queries fail
Date Tue, 03 Apr 2012 01:32:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4621/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Summary
-------

Sqoop free-form query import does not work with Oracle, MySQL, and Hsqldb.

https://issues.apache.org/jira/browse/SQOOP-468

The changes include:
1) Use alias 't1' instead of table name in the qualified names.
2) Add 3 unit tests for Hsqldb, MySQL, and Oracle.


This addresses bug SQOOP-468.
    https://issues.apache.org/jira/browse/SQOOP-468


Diffs
-----

  /src/test/com/cloudera/sqoop/manager/MySQLFreeFormQueryTest.java PRE-CREATION 
  /src/test/com/cloudera/sqoop/manager/OracleFreeFormQueryTest.java PRE-CREATION 
  /src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1308555 
  /src/test/com/cloudera/sqoop/TestFreeFormQueryImport.java PRE-CREATION 

Diff: https://reviews.apache.org/r/4621/diff


Testing
-------

1) The new tests verify that import with a simple free-form query that includes join works
with 3 different DBs.
2) ant test, ant test -Dthirdparty=true, and ant checkstyle


Thanks,

Cheolsoo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message