sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cheolsoo Park" <cheol...@cloudera.com>
Subject Re: Review Request: SQOOP-473 Sqoop import-all-tables fails with MySQL connector
Date Mon, 02 Apr 2012 17:50:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4584/
-----------------------------------------------------------

(Updated 2012-04-02 17:50:28.671860)


Review request for Sqoop.


Summary
-------

All-tables import fails with MySQL:

https://issues.apache.org/jira/browse/SQOOP-473

The change include:

1) Modify toJavaType(), toHiveType(), and toAvroType() methods.
2) Add new unit test for MySQL all-tables import (subclassing TestAllTables).
3) Minor changes to TestAllTables class to make it available for non-Hsqldb servers.


This addresses bug SQOOP-473.
    https://issues.apache.org/jira/browse/SQOOP-473


Diffs (updated)
-----

  src/java/org/apache/sqoop/hive/TableDefWriter.java bfac391 
  src/java/org/apache/sqoop/manager/ConnManager.java 26a2a82 
  src/java/org/apache/sqoop/manager/MySQLManager.java 3254a2c 
  src/java/org/apache/sqoop/manager/OracleManager.java 30401c5 
  src/java/org/apache/sqoop/mapreduce/JdbcExportJob.java a7ea834 
  src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java ff39801 
  src/java/org/apache/sqoop/orm/ClassWriter.java 986934d 
  src/test/com/cloudera/sqoop/TestAllTables.java e6561e9 
  src/test/com/cloudera/sqoop/manager/MySQLAllTablesTest.java e69de29 

Diff: https://reviews.apache.org/r/4584/diff


Testing
-------

1) Verified that MySQL all-tables import is fixed using new unit test.
2) Ran ant test, ant test -Dthirdparty=true, and ant checkstyle.


Thanks,

Cheolsoo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message